LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hp.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
	akpm@linux-foundation.org, arnd@arndb.de, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, jgross@suse.com,
	stefan.bader@canonical.com, luto@amacapital.net, hmh@hmh.eng.br,
	yigal@plexistor.com, konrad.wilk@oracle.com, Elliott@hp.com
Subject: Re: [PATCH v8 7/7] x86, mm: Add set_memory_wt() for WT
Date: Wed, 04 Mar 2015 11:27:14 -0700	[thread overview]
Message-ID: <1425493634.17007.248.camel@misato.fc.hp.com> (raw)
In-Reply-To: <1424961893.17007.139.camel@misato.fc.hp.com>

On Thu, 2015-02-26 at 07:44 -0700, Toshi Kani wrote:
> On Thu, 2015-02-26 at 12:30 +0100, Ingo Molnar wrote:
> > * Toshi Kani <toshi.kani@hp.com> wrote:
> > 
> > > On Wed, 2015-02-25 at 08:22 +0100, Ingo Molnar wrote:
> > > > * Toshi Kani <toshi.kani@hp.com> wrote:
> > > > 
> > > > > +int set_pages_array_wt(struct page **pages, int addrinarray)
> > > > > +{
> > > > > +	return _set_pages_array(pages, addrinarray, _PAGE_CACHE_MODE_WT);
> > > > > +}
> > > > > +EXPORT_SYMBOL(set_pages_array_wt);
> > > > 
> > > > So by default we make new APIs EXPORT_SYMBOL_GPL(): we 
> > > > don't want proprietary modules mucking around with new code 
> > > > PAT interfaces, we only want modules we can analyze and fix 
> > > > in detail.
> > > 
> > > Right.  I have one question for this case.  This 
> > > set_pages_array_wt() extends the set_pages_array_xx() 
> > > family, which are all exported with EXPORT_SYMBOL() 
> > > today.  In this case, should we keep them exported in the 
> > > consistent manner, or should we still use GPL when adding 
> > > a new one?
> > 
> > Still keep it GPL, it's a new API that old modules 
> > obviously don't use.
> 
> Got it. Thanks for the clarification.

Since this is a minor change and there is no other comment at this
point, I've submitted the updated patch 7/7 alone with the following
subject for saving your mail box. :-)

 [PATCH v8-UPDATE 7/7] x86, mm: Add set_memory_wt() for WT

Thanks,
-Toshi


      reply	other threads:[~2015-03-04 18:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25  0:14 [PATCH v8 0/7] Support Write-Through mapping on x86 Toshi Kani
2015-02-25  0:14 ` [PATCH v8 1/7] x86, mm, pat: Set WT to PA7 slot of PAT MSR Toshi Kani
2015-02-25  0:14 ` [PATCH v8 2/7] x86, mm, pat: Change reserve_memtype() to handle WT Toshi Kani
2015-02-25  0:14 ` [PATCH v8 3/7] x86, mm, asm-gen: Add ioremap_wt() for WT Toshi Kani
2015-02-25  0:14 ` [PATCH v8 4/7] x86, mm, pat: Add pgprot_writethrough() " Toshi Kani
2015-02-25  0:14 ` [PATCH v8 5/7] x86, mm, pat: Refactor !pat_enabled handling Toshi Kani
2015-02-25  0:15 ` [PATCH v8 6/7] x86, mm, asm: Add WT support to set_page_memtype() Toshi Kani
2015-02-25  0:15 ` [PATCH v8 7/7] x86, mm: Add set_memory_wt() for WT Toshi Kani
2015-02-25  7:22   ` Ingo Molnar
2015-02-25 15:20     ` Toshi Kani
2015-02-26 11:30       ` Ingo Molnar
2015-02-26 14:44         ` Toshi Kani
2015-03-04 18:27           ` Toshi Kani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425493634.17007.248.camel@misato.fc.hp.com \
    --to=toshi.kani@hp.com \
    --cc=Elliott@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=hmh@hmh.eng.br \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=stefan.bader@canonical.com \
    --cc=tglx@linutronix.de \
    --cc=yigal@plexistor.com \
    --subject='Re: [PATCH v8 7/7] x86, mm: Add set_memory_wt() for WT' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).