LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Staging: rtl8192e: remove assignment of function parameter
@ 2015-03-04 18:53 Matteo Semenzato
  2015-03-05 10:00 ` Sudip Mukherjee
  0 siblings, 1 reply; 2+ messages in thread
From: Matteo Semenzato @ 2015-03-04 18:53 UTC (permalink / raw)
  To: gregkh, mahati.chamarthy, jjin082693, peter.senna, quozl,
	standby24x7, emilgoode, mdcasey, rickard_strandqvist
  Cc: devel, linux-kernel, Matteo Semenzato

From: Matteo Semenzato <mattew8898@gmail.com>

This patch removes the assignment of a function parameter that has no
effect.

Signed-off-by: Matteo Semenzato <mattew8898@gmail.com>
---
 drivers/staging/rtl8192e/rtllib_rx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 1664040..c35a5da 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -1226,7 +1226,6 @@ static void rtllib_rx_indicate_pkt_legacy(struct rtllib_device *ieee,
 		}
 	}
 	kfree(rxb);
-	rxb = NULL;
 }
 
 static int rtllib_rx_InfraAdhoc(struct rtllib_device *ieee, struct sk_buff *skb,
-- 
2.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Staging: rtl8192e: remove assignment of function parameter
  2015-03-04 18:53 [PATCH] Staging: rtl8192e: remove assignment of function parameter Matteo Semenzato
@ 2015-03-05 10:00 ` Sudip Mukherjee
  0 siblings, 0 replies; 2+ messages in thread
From: Sudip Mukherjee @ 2015-03-05 10:00 UTC (permalink / raw)
  To: Matteo Semenzato
  Cc: gregkh, mahati.chamarthy, jjin082693, peter.senna, quozl,
	standby24x7, emilgoode, mdcasey, rickard_strandqvist, devel,
	linux-kernel

On Wed, Mar 04, 2015 at 07:53:10PM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato <mattew8898@gmail.com>
> 
> This patch removes the assignment of a function parameter that has no
> effect.
then by the same logic you can also remove another rxb = NULL in rtllib_rx_InfraAdhoc() function..

regards
sudip
> 
> Signed-off-by: Matteo Semenzato <mattew8898@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtllib_rx.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index 1664040..c35a5da 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -1226,7 +1226,6 @@ static void rtllib_rx_indicate_pkt_legacy(struct rtllib_device *ieee,
>  		}
>  	}
>  	kfree(rxb);
> -	rxb = NULL;
>  }
>  
>  static int rtllib_rx_InfraAdhoc(struct rtllib_device *ieee, struct sk_buff *skb,
> -- 
> 2.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-05 10:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-04 18:53 [PATCH] Staging: rtl8192e: remove assignment of function parameter Matteo Semenzato
2015-03-05 10:00 ` Sudip Mukherjee

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).