LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] dt: spi: fsl-imx-cspi: add explicit compatible strings and required clock properties
@ 2015-03-04 19:12 Matt Porter
  2015-03-05 17:07 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Matt Porter @ 2015-03-04 19:12 UTC (permalink / raw)
  To: Devicetree List, Mark Brown
  Cc: Rob Herring, Mark Rutland, Marek Vasut, Robin Gong,
	Pantelis Antoniou, Linux Kernel Mailing List

The fsl-imx-cspi binding contains language indicating compatible
strings to be used that is not valid for all supported parts
e.g. Should be "fsl,<soc>-cspi" or "fsl,<soc>-ecspi". Fix this
by enumerating the set of valid compatible strings.

The binding is also missing the clocks/clock-names properties
so document these and the two required ipg and per clocks.

Signed-off-by: Matt Porter <mporter@konsulko.com>
---
 Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
index aad527b..523341a 100644
--- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
+++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
@@ -2,11 +2,21 @@
   (CSPI/eCSPI) for i.MX
 
 Required properties:
-- compatible : Should be "fsl,<soc>-cspi" or "fsl,<soc>-ecspi"
+- compatible :
+  - "fsl,imx1-cspi" for SPI compatible with the one integrated on i.MX1
+  - "fsl,imx21-cspi" for SPI compatible with the one integrated on i.MX21
+  - "fsl,imx27-cspi" for SPI compatible with the one integrated on i.MX27
+  - "fsl,imx31-cspi" for SPI compatible with the one integrated on i.MX31
+  - "fsl,imx35-cspi" for SPI compatible with the one integrated on i.MX35
+  - "fsl,imx51-ecspi" for SPI compatible with the one integrated on i.MX51
 - reg : Offset and length of the register set for the device
 - interrupts : Should contain CSPI/eCSPI interrupt
 - fsl,spi-num-chipselects : Contains the number of the chipselect
 - cs-gpios : Specifies the gpio pins to be used for chipselects.
+- clocks : Clock specifiers for both ipg and per clocks.
+- clock-names : Clock names should include both "ipg" and "per"
+See the clock consumer binding,
+	Documentation/devicetree/bindings/clock/clock-bindings.txt
 - dmas: DMA specifiers for tx and rx dma. See the DMA client binding,
 		Documentation/devicetree/bindings/dma/dma.txt
 - dma-names: DMA request names should include "tx" and "rx" if present.
-- 
1.8.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt: spi: fsl-imx-cspi: add explicit compatible strings and required clock properties
  2015-03-04 19:12 [PATCH] dt: spi: fsl-imx-cspi: add explicit compatible strings and required clock properties Matt Porter
@ 2015-03-05 17:07 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2015-03-05 17:07 UTC (permalink / raw)
  To: Matt Porter
  Cc: Devicetree List, Rob Herring, Mark Rutland, Marek Vasut,
	Robin Gong, Pantelis Antoniou, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

On Wed, Mar 04, 2015 at 02:12:58PM -0500, Matt Porter wrote:
> The fsl-imx-cspi binding contains language indicating compatible
> strings to be used that is not valid for all supported parts
> e.g. Should be "fsl,<soc>-cspi" or "fsl,<soc>-ecspi". Fix this
> by enumerating the set of valid compatible strings.

Applied, thanks.  Please use subject lines matching the style for the
subsystem.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-05 17:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-04 19:12 [PATCH] dt: spi: fsl-imx-cspi: add explicit compatible strings and required clock properties Matt Porter
2015-03-05 17:07 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).