LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@stlinux.com,
	rtc-linux@googlegroups.com, wim@iguana.be,
	linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
	linux@roeck-us.net, david.paris@st.com, a.zummo@towertech.it
Subject: Re: [PATCH v5 8/9] rtc: st: add new driver for ST's LPC RTC
Date: Wed, 04 Mar 2015 20:24:32 +0100	[thread overview]
Message-ID: <1425497072.2090.4.camel@tiscali.nl> (raw)
In-Reply-To: <1425492398-27340-9-git-send-email-lee.jones@linaro.org>

Lee Jones schreef op wo 04-03-2015 om 18:06 [+0000]:
> --- /dev/null
> +++ b/drivers/rtc/rtc-st-lpc.c
> @@ -0,0 +1,354 @@
> +/*
> + * rtc-st-lpc.c - ST's LPC RTC, powered by the Low Power Timer
> + *
> + * Copyright (C) 2014 STMicroelectronics Limited
> + *
> + * Author: David Paris <david.paris@st.com> for STMicroelectronics
> + *         Lee Jones <lee.jones@linaro.org> for STMicroelectronics
> + *
> + * Based on the original driver written by Stuart Menefy.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public Licence
> + * as published by the Free Software Foundation; either version
> + * 2 of the Licence, or (at your option) any later version.
> + */

This states the license is GPL v2 or later.

> +MODULE_LICENSE("GPLv2");

This will taint the kernel at module load, won't it? You probably meant
"GPL v2", but only
    MODULE_LICENSE("GPL");

correctly matches the license in the comment at the top of this file. 

(I assume I missed all this when looking at the v4 series.)


Paul Bolle


  reply	other threads:[~2015-03-04 19:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04 18:06 [PATCH v5 0/9] mfd: watchdog: rtc: New driver for ST's LPC IP Lee Jones
2015-03-04 18:06 ` [PATCH v5 1/9] mfd: dt-bindings: Provide human readable defines for LPC mode choosing Lee Jones
2015-03-09 15:27   ` [v5, " Guenter Roeck
2015-03-04 18:06 ` [PATCH v5 2/9] ARM: multi_v7_defconfig: Enable support for ST's LPC Watchdog Lee Jones
2015-03-04 18:06 ` [PATCH v5 3/9] ARM: multi_v7_defconfig: Enable support for ST's LPC RTC Lee Jones
2015-03-04 18:06 ` [PATCH v5 4/9] ARM: STi: DT: STiH407: Add Device Tree node for the LPC Lee Jones
2015-03-04 18:06 ` [PATCH v5 5/9] watchdog: bindings: Provide ST bindings for ST's LPC Watchdog device Lee Jones
2015-03-04 18:06 ` [PATCH v5 6/9] watchdog: st_wdt: Add new driver for ST's LPC Watchdog Lee Jones
2015-03-04 18:06 ` [PATCH v5 7/9] rtc: bindings: Provide ST bindings for ST's LPC RTC device Lee Jones
2015-03-04 18:06 ` [PATCH v5 8/9] rtc: st: add new driver for ST's LPC RTC Lee Jones
2015-03-04 19:24   ` Paul Bolle [this message]
2015-03-05  8:02     ` Lee Jones
2015-03-04 18:06 ` [PATCH v5 9/9] MAINTAINERS: Add Watchdog and RTC files to STI's maintainer entry Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425497072.2090.4.camel@tiscali.nl \
    --to=pebolle@tiscali.nl \
    --cc=a.zummo@towertech.it \
    --cc=david.paris@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@stlinux.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=rtc-linux@googlegroups.com \
    --cc=wim@iguana.be \
    --subject='Re: [PATCH v5 8/9] rtc: st: add new driver for ST'\''s LPC RTC' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).