LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Arjan van de Ven <arjan@linux.intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	"Li, Aubrey" <aubrey.li@linux.intel.com>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len.Brown@intel.com, x86@kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: Bypass legacy PIC and PIT on ACPI hardware reduced platform
Date: Wed, 04 Mar 2015 20:18:57 +0000	[thread overview]
Message-ID: <1425500337.3838.138.camel@linux.intel.com> (raw)
In-Reply-To: <20150304095011.GH3233@pd.tnic>

On Wed, 2015-03-04 at 10:50 +0100, Borislav Petkov wrote:
> On Wed, Mar 04, 2015 at 12:43:08AM -0800, Arjan van de Ven wrote:
> > >
> > >Using 'acpi_gbl_reduced_hardware' flag outside the ACPI code
> > >is a mistake.
> > 
> > ideally, the presence of that flag in the firmware table will clear/set more global settings,
> > for example, having that flag should cause the 8042 input code to not probe for the 8042.
> > 
> > for interrupts, there really ought to be a "apic first/only" mode, which is then used on
> > all modern systems (not just hw reduced).
> 
> Do we need some sort of platform-specific querying interfaces now too,
> similar to cpu_has()? I.e., platform_has()...
> 
> 	if (platform_has(X86_PLATFORM_REDUCED_HW))
> 		do stuff..

ACPI hw reduced is not an x86 specific concept so quite possibly yes.

ACPI is the usual source for a variety of generic platform information
such as absence and presence of prehistoric PC compatibility goo -
increasingly so in fact. It tells you if the device is probably a
tablet, if it is more efficient to idle via suspend/resume or by asking
the cpu to idle. It tells you if low power modes are supported and so
on.

I don't think it makes sense to treat "ACPI reduced" as some kind of
platform concept. You could easily get basically identical hardware that
is or is not "hw reduced" depending upon firmware choices.

Alan



      parent reply	other threads:[~2015-03-04 20:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04  3:23 Li, Aubrey
2015-03-04  5:08 ` Ingo Molnar
2015-03-04  5:26   ` Li, Aubrey
2015-03-04  5:31     ` Ingo Molnar
2015-03-04  6:04       ` Li, Aubrey
2015-03-04  7:37         ` Ingo Molnar
2015-03-04  8:43           ` Arjan van de Ven
2015-03-04  9:50             ` Borislav Petkov
2015-03-04 14:16               ` Rafael J. Wysocki
2015-03-04 14:05                 ` Borislav Petkov
2015-03-04 14:38                   ` Rafael J. Wysocki
2015-03-04 20:21                   ` Alan Cox
2015-03-04 21:52                     ` Rafael J. Wysocki
2015-03-05 11:26                       ` Li, Aubrey
2015-03-05 16:05                       ` Alan Cox
2015-03-04 14:36               ` Arjan van de Ven
2015-03-04 20:11                 ` Ingo Molnar
2015-03-05 11:13                   ` Li, Aubrey
2015-03-05 11:36                     ` Ingo Molnar
2015-03-05 12:42                       ` Li, Aubrey
2015-03-05 16:06                         ` Alan Cox
2015-03-09 23:26                         ` Li, Aubrey
2015-03-10  8:06                           ` Ingo Molnar
2015-03-11  4:14                             ` Li, Aubrey
2015-03-04 20:18               ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425500337.3838.138.camel@linux.intel.com \
    --to=alan@linux.intel.com \
    --cc=Len.Brown@intel.com \
    --cc=arjan@linux.intel.com \
    --cc=aubrey.li@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH] x86: Bypass legacy PIC and PIT on ACPI hardware reduced platform' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).