From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759281AbbCDUT1 (ORCPT ); Wed, 4 Mar 2015 15:19:27 -0500 Received: from mga02.intel.com ([134.134.136.20]:45118 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755753AbbCDUT0 (ORCPT ); Wed, 4 Mar 2015 15:19:26 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,689,1418112000"; d="scan'208";a="462565210" Message-ID: <1425500337.3838.138.camel@linux.intel.com> Subject: Re: [PATCH] x86: Bypass legacy PIC and PIT on ACPI hardware reduced platform From: Alan Cox To: Borislav Petkov Cc: Arjan van de Ven , Ingo Molnar , "Li, Aubrey" , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , "Rafael J. Wysocki" , Len.Brown@intel.com, x86@kernel.org, LKML Date: Wed, 04 Mar 2015 20:18:57 +0000 In-Reply-To: <20150304095011.GH3233@pd.tnic> References: <54F67ACC.3010500@linux.intel.com> <20150304050858.GB5158@gmail.com> <54F69774.2050400@linux.intel.com> <20150304053106.GA3701@gmail.com> <54F6A08B.2010105@linux.intel.com> <20150304073717.GA11736@gmail.com> <54F6C59C.706@linux.intel.com> <20150304095011.GH3233@pd.tnic> Organization: Intel Corporation Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9 (3.12.9-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-03-04 at 10:50 +0100, Borislav Petkov wrote: > On Wed, Mar 04, 2015 at 12:43:08AM -0800, Arjan van de Ven wrote: > > > > > >Using 'acpi_gbl_reduced_hardware' flag outside the ACPI code > > >is a mistake. > > > > ideally, the presence of that flag in the firmware table will clear/set more global settings, > > for example, having that flag should cause the 8042 input code to not probe for the 8042. > > > > for interrupts, there really ought to be a "apic first/only" mode, which is then used on > > all modern systems (not just hw reduced). > > Do we need some sort of platform-specific querying interfaces now too, > similar to cpu_has()? I.e., platform_has()... > > if (platform_has(X86_PLATFORM_REDUCED_HW)) > do stuff.. ACPI hw reduced is not an x86 specific concept so quite possibly yes. ACPI is the usual source for a variety of generic platform information such as absence and presence of prehistoric PC compatibility goo - increasingly so in fact. It tells you if the device is probably a tablet, if it is more efficient to idle via suspend/resume or by asking the cpu to idle. It tells you if low power modes are supported and so on. I don't think it makes sense to treat "ACPI reduced" as some kind of platform concept. You could easily get basically identical hardware that is or is not "hw reduced" depending upon firmware choices. Alan