LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Lee Jones <lee.jones@linaro.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Stanimir Varbanov <svarbanov@mm-sol.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2] mfd: Add specific compatible strings for Qualcomm's SPMI PMIC's
Date: Thu, 05 Mar 2015 10:14:38 +0200	[thread overview]
Message-ID: <1425543278.5705.11.camel@mm-sol.com> (raw)
In-Reply-To: <54F75690.3010406@codeaurora.org>


On Wed, 2015-03-04 at 11:01 -0800, Stephen Boyd wrote:
> On 03/04/15 02:19, Ivan T. Ivanov wrote:
> > diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c
> > index 4b8beb2..a1af4e5 100644
> > --- a/drivers/mfd/qcom-spmi-pmic.c
> > +++ b/drivers/mfd/qcom-spmi-pmic.c
> > 
> > +
> > +static void pmic_spmi_show_revid(struct regmap *map, struct device *dev)
> > +{
> > +       unsigned int rev2, minor, major, type, subtype;
> > +       int ret;
> > +
> > +       ret = regmap_read(map, PMIC_TYPE, &type);
> > +       if (ret < 0)
> > +               return;
> > +
> > +       if (type != PMIC_TYPE_VALUE)
> > +               return;
> > +
> > +       ret = regmap_read(map, PMIC_SUBTYPE, &subtype);
> > +       if (ret < 0)
> > +               return;
> > +
> > +       if (subtype > ARRAY_SIZE(pmic_spmi_id_table))
> > +               return;
> > +
> > +       rev2 = regmap_read(map, PMIC_REV2, &rev2);
> 
> ret = ?

Ouch. will fix.

> 
> > 
> > +
> > +       dev_info(dev, "%s-v%d.%d detected\n",
> > +                       pmic_spmi_id_table[subtype].compatible, major, minor);
> > +}
> > 
> 
> I wonder if this should be dev_dbg.

It is not so much verbose, right? I could cut "detected". I will like to keep it.

Thanks, 
Ivan

  reply	other threads:[~2015-03-05  8:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04 10:19 Ivan T. Ivanov
2015-03-04 19:01 ` Stephen Boyd
2015-03-05  8:14   ` Ivan T. Ivanov [this message]
2015-03-04 19:05 ` Stephen Boyd
2015-03-05  8:16   ` Ivan T. Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425543278.5705.11.camel@mm-sol.com \
    --to=iivanov@mm-sol.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=sboyd@codeaurora.org \
    --cc=svarbanov@mm-sol.com \
    --subject='Re: [PATCH v2] mfd: Add specific compatible strings for Qualcomm'\''s SPMI PMIC'\''s' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).