From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754560AbbCEIOp (ORCPT ); Thu, 5 Mar 2015 03:14:45 -0500 Received: from ns.mm-sol.com ([37.157.136.199]:44789 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751846AbbCEIOn (ORCPT ); Thu, 5 Mar 2015 03:14:43 -0500 Message-ID: <1425543278.5705.11.camel@mm-sol.com> Subject: Re: [PATCH v2] mfd: Add specific compatible strings for Qualcomm's SPMI PMIC's From: "Ivan T. Ivanov" To: Stephen Boyd Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Lee Jones , Samuel Ortiz , Stanimir Varbanov , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Date: Thu, 05 Mar 2015 10:14:38 +0200 In-Reply-To: <54F75690.3010406@codeaurora.org> References: <1425464365-3291-1-git-send-email-iivanov@mm-sol.com> <54F75690.3010406@codeaurora.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.13.7-fta1.2~trusty Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-03-04 at 11:01 -0800, Stephen Boyd wrote: > On 03/04/15 02:19, Ivan T. Ivanov wrote: > > diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c > > index 4b8beb2..a1af4e5 100644 > > --- a/drivers/mfd/qcom-spmi-pmic.c > > +++ b/drivers/mfd/qcom-spmi-pmic.c > > > > + > > +static void pmic_spmi_show_revid(struct regmap *map, struct device *dev) > > +{ > > + unsigned int rev2, minor, major, type, subtype; > > + int ret; > > + > > + ret = regmap_read(map, PMIC_TYPE, &type); > > + if (ret < 0) > > + return; > > + > > + if (type != PMIC_TYPE_VALUE) > > + return; > > + > > + ret = regmap_read(map, PMIC_SUBTYPE, &subtype); > > + if (ret < 0) > > + return; > > + > > + if (subtype > ARRAY_SIZE(pmic_spmi_id_table)) > > + return; > > + > > + rev2 = regmap_read(map, PMIC_REV2, &rev2); > > ret = ? Ouch. will fix. > > > > > + > > + dev_info(dev, "%s-v%d.%d detected\n", > > + pmic_spmi_id_table[subtype].compatible, major, minor); > > +} > > > > I wonder if this should be dev_dbg. It is not so much verbose, right? I could cut "detected". I will like to keep it. Thanks, Ivan