LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] bgmac: ratelimit warning messages
@ 2015-03-06 18:17 Peter Senna Tschudin
2015-03-06 19:50 ` Joe Perches
2015-03-06 23:27 ` Rafał Miłecki
0 siblings, 2 replies; 4+ messages in thread
From: Peter Senna Tschudin @ 2015-03-06 18:17 UTC (permalink / raw)
To: davem, hauke, w-lkml, zajec5, joe, netdev, linux-kernel
Cc: Peter Senna Tschudin
On my test environment the troughput of a file transfer drops from
4.4Mbps to 116Kbps due the number of repeated warning messages.
Adding printk_ratelimit() solves the issue without removing the
warning message.
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/net/ethernet/broadcom/bgmac.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index 676ffe0..d1a259b 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -302,7 +302,7 @@ static int bgmac_dma_rx_skb_for_slot(struct bgmac *bgmac,
slot->skb = skb;
slot->dma_addr = dma_addr;
- if (slot->dma_addr & 0xC0000000)
+ if ((slot->dma_addr & 0xC0000000) && printk_ratelimit())
bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n");
return 0;
@@ -505,7 +505,7 @@ static int bgmac_dma_alloc(struct bgmac *bgmac)
ring->mmio_base);
goto err_dma_free;
}
- if (ring->dma_base & 0xC0000000)
+ if ((ring->dma_base & 0xC0000000) && printk_ratelimit())
bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n");
ring->unaligned = bgmac_dma_unaligned(bgmac, ring,
@@ -536,7 +536,7 @@ static int bgmac_dma_alloc(struct bgmac *bgmac)
err = -ENOMEM;
goto err_dma_free;
}
- if (ring->dma_base & 0xC0000000)
+ if ((ring->dma_base & 0xC0000000) && printk_ratelimit())
bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n");
ring->unaligned = bgmac_dma_unaligned(bgmac, ring,
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] bgmac: ratelimit warning messages
2015-03-06 18:17 [PATCH] bgmac: ratelimit warning messages Peter Senna Tschudin
@ 2015-03-06 19:50 ` Joe Perches
2015-03-06 23:27 ` Rafał Miłecki
1 sibling, 0 replies; 4+ messages in thread
From: Joe Perches @ 2015-03-06 19:50 UTC (permalink / raw)
To: Peter Senna Tschudin; +Cc: davem, hauke, w-lkml, zajec5, netdev, linux-kernel
On Fri, 2015-03-06 at 19:17 +0100, Peter Senna Tschudin wrote:
> On my test environment the troughput of a file transfer drops from
> 4.4Mbps to 116Kbps due the number of repeated warning messages.
> Adding printk_ratelimit() solves the issue without removing the
> warning message.
What value is there for this message being emitted more than once?
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -302,7 +302,7 @@ static int bgmac_dma_rx_skb_for_slot(struct bgmac *bgmac,
> slot->skb = skb;
> slot->dma_addr = dma_addr;
>
> - if (slot->dma_addr & 0xC0000000)
> + if ((slot->dma_addr & 0xC0000000) && printk_ratelimit())
> bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n");
Maybe better as a static function
static void check_translate_address(struct bgmac *bgmac, dma_addr_t addr)
{
static bool printed;
if (!printed && (addr & (dma_addr_t)0xC0000000)))
printed = true;
bgmac_warn(bgmac, etc...);
}
}
[...]
check_translate_address(bgmac, slot->dma_addr);
> return 0;
> @@ -505,7 +505,7 @@ static int bgmac_dma_alloc(struct bgmac *bgmac)
> ring->mmio_base);
> goto err_dma_free;
> }
> - if (ring->dma_base & 0xC0000000)
> + if ((ring->dma_base & 0xC0000000) && printk_ratelimit())
> bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n");
>
> ring->unaligned = bgmac_dma_unaligned(bgmac, ring,
> @@ -536,7 +536,7 @@ static int bgmac_dma_alloc(struct bgmac *bgmac)
> err = -ENOMEM;
> goto err_dma_free;
> }
> - if (ring->dma_base & 0xC0000000)
> + if ((ring->dma_base & 0xC0000000) && printk_ratelimit())
> bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n");
>
> ring->unaligned = bgmac_dma_unaligned(bgmac, ring,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bgmac: ratelimit warning messages
2015-03-06 18:17 [PATCH] bgmac: ratelimit warning messages Peter Senna Tschudin
2015-03-06 19:50 ` Joe Perches
@ 2015-03-06 23:27 ` Rafał Miłecki
2015-03-07 9:39 ` Peter Senna Tschudin
1 sibling, 1 reply; 4+ messages in thread
From: Rafał Miłecki @ 2015-03-06 23:27 UTC (permalink / raw)
To: Peter Senna Tschudin
Cc: David Miller, Hauke Mehrtens, w-lkml, Joe Perches,
Network Development, Linux Kernel Mailing List
On 6 March 2015 at 19:17, Peter Senna Tschudin <peter.senna@gmail.com> wrote:
> On my test environment the troughput of a file transfer drops from
> 4.4Mbps to 116Kbps due the number of repeated warning messages.
> Adding printk_ratelimit() solves the issue without removing the
> warning message.
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> drivers/net/ethernet/broadcom/bgmac.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> index 676ffe0..d1a259b 100644
> --- a/drivers/net/ethernet/broadcom/bgmac.c
> +++ b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -302,7 +302,7 @@ static int bgmac_dma_rx_skb_for_slot(struct bgmac *bgmac,
> slot->skb = skb;
> slot->dma_addr = dma_addr;
>
> - if (slot->dma_addr & 0xC0000000)
> + if ((slot->dma_addr & 0xC0000000) && printk_ratelimit())
> bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n");
>
> return 0;
Nack. Please just drop this code.
>From what I understand network works for you. I've also checked
Broadcom's open source code, and on SoC we can always safely write
whole low 32b.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bgmac: ratelimit warning messages
2015-03-06 23:27 ` Rafał Miłecki
@ 2015-03-07 9:39 ` Peter Senna Tschudin
0 siblings, 0 replies; 4+ messages in thread
From: Peter Senna Tschudin @ 2015-03-07 9:39 UTC (permalink / raw)
To: Rafał Miłecki
Cc: David Miller, Hauke Mehrtens, Wilfried Klaebe, Joe Perches,
Network Development, Linux Kernel Mailing List
On Sat, Mar 7, 2015 at 12:27 AM, Rafał Miłecki <zajec5@gmail.com> wrote:
> On 6 March 2015 at 19:17, Peter Senna Tschudin <peter.senna@gmail.com> wrote:
>> On my test environment the troughput of a file transfer drops from
>> 4.4Mbps to 116Kbps due the number of repeated warning messages.
>> Adding printk_ratelimit() solves the issue without removing the
>> warning message.
>>
>> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
>> ---
>> drivers/net/ethernet/broadcom/bgmac.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
>> index 676ffe0..d1a259b 100644
>> --- a/drivers/net/ethernet/broadcom/bgmac.c
>> +++ b/drivers/net/ethernet/broadcom/bgmac.c
>> @@ -302,7 +302,7 @@ static int bgmac_dma_rx_skb_for_slot(struct bgmac *bgmac,
>> slot->skb = skb;
>> slot->dma_addr = dma_addr;
>>
>> - if (slot->dma_addr & 0xC0000000)
>> + if ((slot->dma_addr & 0xC0000000) && printk_ratelimit())
>> bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n");
>>
>> return 0;
>
> Nack. Please just drop this code.
>
> From what I understand network works for you. I've also checked
> Broadcom's open source code, and on SoC we can always safely write
> whole low 32b.
Yes, it works for me, even after:
-CONFIG_PAGE_OFFSET=0xC0000000
+CONFIG_PAGE_OFFSET=0x40000000
...
+CONFIG_VMSPLIT_1G=y
+# CONFIG_VMSPLIT_3G is not set
The page offset change was made by make menuconfig as a consequence of
CONFIG_VMSPLIT_1G. After the Kconfig changes the throughput is almost
40 times worst, but commenting the warnings fixes the issue. I'll send
V2 removing the messages completely.
--
Peter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-07 9:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-06 18:17 [PATCH] bgmac: ratelimit warning messages Peter Senna Tschudin
2015-03-06 19:50 ` Joe Perches
2015-03-06 23:27 ` Rafał Miłecki
2015-03-07 9:39 ` Peter Senna Tschudin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).