LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Willy Tarreau <willy@meta-x.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] staging: panel: return register value
Date: Sun,  8 Mar 2015 23:07:25 +0530	[thread overview]
Message-ID: <1425836246-15355-2-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1425836246-15355-1-git-send-email-sudipm.mukherjee@gmail.com>

we were returning success even if the module failed to register.
now we are returning the actual return value, success or error.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/staging/panel/panel.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 3ef3dcf..b4c143a 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -2360,11 +2360,6 @@ static int __init panel_init_module(void)
 		return -ENODEV;
 	}
 
-	if (parport_register_driver(&panel_driver)) {
-		pr_err("could not register with parport. Aborting.\n");
-		return -EIO;
-	}
-
 	if (pprt)
 		pr_info("driver version " PANEL_VERSION
 			" registered on parport%d (io=0x%lx).\n", parport,
@@ -2375,7 +2370,7 @@ static int __init panel_init_module(void)
 	/* tells various subsystems about the fact that initialization
 	   is finished */
 	init_in_progress = 0;
-	return 0;
+	return parport_register_driver(&panel_driver);
 }
 
 static void __exit panel_cleanup_module(void)
-- 
1.8.1.2


  reply	other threads:[~2015-03-08 17:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-08 17:37 [PATCH 1/3] staging: panel: register reboot Sudip Mukherjee
2015-03-08 17:37 ` Sudip Mukherjee [this message]
2015-03-09  6:30   ` [PATCH 2/3] staging: panel: return register value Willy Tarreau
2015-03-09 13:35     ` Sudip Mukherjee
2015-03-09 15:05       ` Willy Tarreau
2015-03-08 17:37 ` [PATCH 3/3] staging: panel: remove initialization check Sudip Mukherjee
2015-03-09  6:20   ` Willy Tarreau
2015-03-09  6:19 ` [PATCH 1/3] staging: panel: register reboot Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425836246-15355-2-git-send-email-sudipm.mukherjee@gmail.com \
    --to=sudipm.mukherjee@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@meta-x.org \
    --subject='Re: [PATCH 2/3] staging: panel: return register value' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).