From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932149AbbCHRhq (ORCPT ); Sun, 8 Mar 2015 13:37:46 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:37504 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932103AbbCHRhn (ORCPT ); Sun, 8 Mar 2015 13:37:43 -0400 From: Sudip Mukherjee To: Willy Tarreau , Greg Kroah-Hartman Cc: Sudip Mukherjee , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] staging: panel: return register value Date: Sun, 8 Mar 2015 23:07:25 +0530 Message-Id: <1425836246-15355-2-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1425836246-15355-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1425836246-15355-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org we were returning success even if the module failed to register. now we are returning the actual return value, success or error. Signed-off-by: Sudip Mukherjee --- drivers/staging/panel/panel.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index 3ef3dcf..b4c143a 100644 --- a/drivers/staging/panel/panel.c +++ b/drivers/staging/panel/panel.c @@ -2360,11 +2360,6 @@ static int __init panel_init_module(void) return -ENODEV; } - if (parport_register_driver(&panel_driver)) { - pr_err("could not register with parport. Aborting.\n"); - return -EIO; - } - if (pprt) pr_info("driver version " PANEL_VERSION " registered on parport%d (io=0x%lx).\n", parport, @@ -2375,7 +2370,7 @@ static int __init panel_init_module(void) /* tells various subsystems about the fact that initialization is finished */ init_in_progress = 0; - return 0; + return parport_register_driver(&panel_driver); } static void __exit panel_cleanup_module(void) -- 1.8.1.2