LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe
Date: Tue, 10 Mar 2015 10:10:56 +0200 [thread overview]
Message-ID: <1425975056.2440.24.camel@mm-sol.com> (raw)
In-Reply-To: <20150309182841.GW28806@sirena.org.uk>
On Mon, 2015-03-09 at 18:28 +0000, Mark Brown wrote:
> On Mon, Mar 09, 2015 at 10:23:35AM +0200, Ivan T. Ivanov wrote:
> > Hi,
>
> Don't reply off list unless there's a good reason...
Sorry, it was not intentional. Wrong button.
>
> > > Any new GPIO users should really be using the gpiod API, however this is
> > > duplicating core functionality so as Stephen says why are we doing this?
>
> > About the API usage, point taken. GPIO requesting part is more important
> > in this case. pinctrl core did not request pins and wrong DT configuration
> > could lead to surprises without any warnings or errors.
>
> That doesn't answer my concern at all.
I am not sure that I am following you.
I can not use spi_master::cs_gpios, which is populated by
of_spi_register_master(), because spi_register_master()
populate SPI devices and they could issue setup method.
Requesting GPIO's in core framework is also not a easy
option because of arguments here[1].
Probably I am still missing something.
Regards,
Ivan
[1] https://lkml.org/lkml/2014/5/24/75
next prev parent reply other threads:[~2015-03-10 8:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 15:26 [PATCH 1/2] spi: qup: Fix cs-num DT property parsing Ivan T. Ivanov
2015-03-06 15:26 ` [PATCH 2/2] spi: qup: Request CS GPIO's during probe Ivan T. Ivanov
2015-03-06 18:34 ` Stephen Boyd
2015-03-09 8:20 ` Ivan T. Ivanov
2015-03-09 18:53 ` Stephen Boyd
2015-03-10 8:31 ` Ivan T. Ivanov
2015-03-17 11:02 ` Ivan T. Ivanov
2015-03-07 10:59 ` Mark Brown
[not found] ` <1425889415.2440.10.camel@mm-sol.com>
[not found] ` <20150309182841.GW28806@sirena.org.uk>
2015-03-10 8:10 ` Ivan T. Ivanov [this message]
2015-03-10 11:06 ` Mark Brown
2015-03-10 12:53 ` Ivan T. Ivanov
2015-03-10 20:47 ` Mark Brown
2015-03-07 11:01 ` [PATCH 1/2] spi: qup: Fix cs-num DT property parsing Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425975056.2440.24.camel@mm-sol.com \
--to=iivanov@mm-sol.com \
--cc=broonie@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--subject='Re: [PATCH 2/2] spi: qup: Request CS GPIO'\''s during probe' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).