LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe
Date: Tue, 10 Mar 2015 14:53:17 +0200	[thread overview]
Message-ID: <1425991997.12581.1.camel@mm-sol.com> (raw)
In-Reply-To: <20150310110638.GD28806@sirena.org.uk>


On Tue, 2015-03-10 at 11:06 +0000, Mark Brown wrote:
> On Tue, Mar 10, 2015 at 10:10:56AM +0200, Ivan T. Ivanov wrote:
> > On Mon, 2015-03-09 at 18:28 +0000, Mark Brown wrote:
> 
> > > > About the API usage, point taken. GPIO requesting part is more important
> > > > in this case. pinctrl core did not request pins and wrong DT configuration
> > > > could lead to surprises without any warnings or errors.
> 
> > > That doesn't answer my concern at all.
> 
> > I am not sure that I am following you.
> 
> > I can not use spi_master::cs_gpios, which is populated by
> > of_spi_register_master(), because spi_register_master()
> > populate SPI devices and they could issue setup method.
> 
> I'm sorry but I can't parse the above.  What does "they could issue
> setup method" mean and why is it a problem?

Client drivers could execute spi_setup() in probe(), so we have
to ensure that CS GPIO's are available before this, no?

> 
> > Requesting GPIO's in core framework is also not a easy
> > option because of arguments here[1].
> 
> We should really fix that though.
> 

I think that pinctrl framework should automatically
request pins belonging to group when state is selected.

Regards,
Ivan

  reply	other threads:[~2015-03-10 12:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06 15:26 [PATCH 1/2] spi: qup: Fix cs-num DT property parsing Ivan T. Ivanov
2015-03-06 15:26 ` [PATCH 2/2] spi: qup: Request CS GPIO's during probe Ivan T. Ivanov
2015-03-06 18:34   ` Stephen Boyd
2015-03-09  8:20     ` Ivan T. Ivanov
2015-03-09 18:53       ` Stephen Boyd
2015-03-10  8:31         ` Ivan T. Ivanov
2015-03-17 11:02         ` Ivan T. Ivanov
2015-03-07 10:59   ` Mark Brown
     [not found]     ` <1425889415.2440.10.camel@mm-sol.com>
     [not found]       ` <20150309182841.GW28806@sirena.org.uk>
2015-03-10  8:10         ` Ivan T. Ivanov
2015-03-10 11:06           ` Mark Brown
2015-03-10 12:53             ` Ivan T. Ivanov [this message]
2015-03-10 20:47               ` Mark Brown
2015-03-07 11:01 ` [PATCH 1/2] spi: qup: Fix cs-num DT property parsing Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425991997.12581.1.camel@mm-sol.com \
    --to=iivanov@mm-sol.com \
    --cc=broonie@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --subject='Re: [PATCH 2/2] spi: qup: Request CS GPIO'\''s during probe' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).