LKML Archive on
help / color / mirror / Atom feed
* [PATCH v2] selftests: kcmp build fails when invoked from kselftest target
@ 2015-03-11  0:08 Shuah Khan
  2015-03-11  2:19 ` Michael Ellerman
  0 siblings, 1 reply; 3+ messages in thread
From: Shuah Khan @ 2015-03-11  0:08 UTC (permalink / raw)
  To: gorcunov, akpm, tranmanphong, mpe; +Cc: Shuah Khan, linux-kernel, linux-api

kcmp Makefile doesn't have an explicit build rule. As a result,
kcmp build fails, when it is run from top level Makefile target
kselftest. Without the explicit rule, make works only when it is
run in the current directory or from selftests directory. Add an
explicit build rule to fix the problem. In addition, build fails
as it can't find kcmp.h. Fix it by passing CFLAGS.

Signed-off-by: Shuah Khan <>
v2: Added deleted pre-requisite back in to address review

 tools/testing/selftests/kcmp/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile
index ff0eefd..d615e9c 100644
--- a/tools/testing/selftests/kcmp/Makefile
+++ b/tools/testing/selftests/kcmp/Makefile
@@ -1,8 +1,11 @@
-CFLAGS += -I../../../../usr/include/
+CFLAGS += -I../../../../include/uapi -I../../../../usr/include/
 all: kcmp_test
+	$(CC) $(CFLAGS) kcmp_test.c -o kcmp_test
 run_tests: all
 	@./kcmp_test || echo "kcmp_test: [FAIL]"

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-11 13:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-11  0:08 [PATCH v2] selftests: kcmp build fails when invoked from kselftest target Shuah Khan
2015-03-11  2:19 ` Michael Ellerman
2015-03-11 13:30   ` Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).