From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752348AbbCKCTm (ORCPT ); Tue, 10 Mar 2015 22:19:42 -0400 Received: from ozlabs.org ([103.22.144.67]:47842 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746AbbCKCTj (ORCPT ); Tue, 10 Mar 2015 22:19:39 -0400 Message-ID: <1426040377.20917.8.camel@ellerman.id.au> Subject: Re: [PATCH v2] selftests: kcmp build fails when invoked from kselftest target From: Michael Ellerman To: Shuah Khan Cc: gorcunov@openvz.org, akpm@linux-foundation.org, tranmanphong@gmail.com, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Date: Wed, 11 Mar 2015 13:19:37 +1100 In-Reply-To: <1426032512-10353-1-git-send-email-shuahkh@osg.samsung.com> References: <1426032512-10353-1-git-send-email-shuahkh@osg.samsung.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-10 at 18:08 -0600, Shuah Khan wrote: > kcmp Makefile doesn't have an explicit build rule. As a result, > kcmp build fails, when it is run from top level Makefile target > kselftest. Without the explicit rule, make works only when it is > run in the current directory or from selftests directory. Add an > explicit build rule to fix the problem. This should be fixed properly using my patch to filter -rR or similar. > In addition, build fails > as it can't find kcmp.h. Fix it by passing CFLAGS. That is also wrong. It should *not* be looking in include/uapi. If it needs headers then it should be using the *exported* headers, which are in ../../../../usr/include as the existing CFLAGS specifiy. Those headers are installed as part of 'make headers_install'. cheers