LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] drm/bridge: tc358767: fix mode_valid's return type
@ 2018-04-24 13:14 Luc Van Oostenryck
  2018-04-26 23:22 ` Laurent Pinchart
  0 siblings, 1 reply; 2+ messages in thread
From: Luc Van Oostenryck @ 2018-04-24 13:14 UTC (permalink / raw)
  To: linux-kernel
  Cc: Luc Van Oostenryck, Archit Taneja, Andrzej Hajda,
	Laurent Pinchart, David Airlie, dri-devel

The method struct drm_connector_helper_funcs::mode_valid is defined
as returning an 'enum drm_mode_status' but the driver implementation
for this method uses an 'int' for it.

Fix this by using 'enum drm_mode_status' in the driver too.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
 drivers/gpu/drm/bridge/tc358767.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index 08ab7d6ae..0fd9cf275 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -1102,7 +1102,7 @@ static bool tc_bridge_mode_fixup(struct drm_bridge *bridge,
 	return true;
 }
 
-static int tc_connector_mode_valid(struct drm_connector *connector,
+static enum drm_mode_status tc_connector_mode_valid(struct drm_connector *connector,
 				   struct drm_display_mode *mode)
 {
 	/* DPI interface clock limitation: upto 154 MHz */
-- 
2.17.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/bridge: tc358767: fix mode_valid's return type
  2018-04-24 13:14 [PATCH] drm/bridge: tc358767: fix mode_valid's return type Luc Van Oostenryck
@ 2018-04-26 23:22 ` Laurent Pinchart
  0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2018-04-26 23:22 UTC (permalink / raw)
  To: Luc Van Oostenryck
  Cc: linux-kernel, Archit Taneja, Andrzej Hajda, David Airlie, dri-devel

Hi Luc,

Thank you for the patch.

On Tuesday, 24 April 2018 16:14:52 EEST Luc Van Oostenryck wrote:
> The method struct drm_connector_helper_funcs::mode_valid is defined
> as returning an 'enum drm_mode_status' but the driver implementation
> for this method uses an 'int' for it.
> 
> Fix this by using 'enum drm_mode_status' in the driver too.
> 
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/bridge/tc358767.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/tc358767.c
> b/drivers/gpu/drm/bridge/tc358767.c index 08ab7d6ae..0fd9cf275 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -1102,7 +1102,7 @@ static bool tc_bridge_mode_fixup(struct drm_bridge
> *bridge, return true;
>  }
> 
> -static int tc_connector_mode_valid(struct drm_connector *connector,
> +static enum drm_mode_status tc_connector_mode_valid(struct drm_connector
> *connector, struct drm_display_mode *mode)
>  {
>  	/* DPI interface clock limitation: upto 154 MHz */

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-26 23:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 13:14 [PATCH] drm/bridge: tc358767: fix mode_valid's return type Luc Van Oostenryck
2018-04-26 23:22 ` Laurent Pinchart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).