LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: shuahkh@osg.samsung.com
Cc: <linux-kernel@vger.kernel.org>,
	davej@codemonkey.org.uk, mmarek@suse.cz,
	linux-api@vger.kernel.org
Subject: [PATCH v4 8/9] selftests/mqueue: Use implicit rules
Date: Wed, 11 Mar 2015 15:06:04 +1100	[thread overview]
Message-ID: <1426046765-19289-8-git-send-email-mpe@ellerman.id.au> (raw)
In-Reply-To: <1426046765-19289-1-git-send-email-mpe@ellerman.id.au>

There's no need to open-code the build rules, use the implicit ones.

This has the nice side effect of enabling cross compilation.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 tools/testing/selftests/mqueue/Makefile | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/tools/testing/selftests/mqueue/Makefile b/tools/testing/selftests/mqueue/Makefile
index 6ca7261b55dc..ed85a1d7ee36 100644
--- a/tools/testing/selftests/mqueue/Makefile
+++ b/tools/testing/selftests/mqueue/Makefile
@@ -1,6 +1,11 @@
-all:
-	gcc -O2 mq_open_tests.c -o mq_open_tests -lrt
-	gcc -O2 -o mq_perf_tests mq_perf_tests.c -lrt -lpthread -lpopt
+TEST_PROGS := mq_open_tests mq_perf_tests
+
+CFLAGS += -O2
+LDLIBS += -lrt
+
+mq_perf_tests: LDLIBS += -lpthread -lpopt
+
+all: $(TEST_PROGS)
 
 include ../lib.mk
 
@@ -9,12 +14,10 @@ override define RUN_TESTS
 	@./mq_perf_tests || echo "selftests: mq_perf_tests [FAIL]"
 endef
 
-TEST_PROGS := mq_open_tests mq_perf_tests
-
 override define EMIT_TESTS
 	echo "./mq_open_tests /test1 || echo \"selftests: mq_open_tests [FAIL]\""
 	echo "./mq_perf_tests || echo \"selftests: mq_perf_tests [FAIL]\""
 endef
 
 clean:
-	rm -f mq_open_tests mq_perf_tests
+	rm -f $(TEST_PROGS)
-- 
2.1.0


  parent reply	other threads:[~2015-03-11  4:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11  4:05 [PATCH v4 1/9] kbuild: Don't pass -rR to selftest makefiles Michael Ellerman
2015-03-11  4:05 ` [PATCH v4 2/9] kbuild: Don't pass LDFLAGS to selftest Makefile Michael Ellerman
2015-03-11 16:08   ` Shuah Khan
2015-03-13 18:06   ` Shuah Khan
2015-03-11  4:05 ` [PATCH v4 3/9] selftests: Introduce minimal shared logic for running tests Michael Ellerman
2015-03-13 17:19   ` Shuah Khan
2015-03-13 20:28     ` Shuah Khan
2015-03-11  4:06 ` [PATCH v4 4/9] selftests: Add install target Michael Ellerman
2015-03-11 13:18   ` Shuah Khan
2015-03-11 16:03     ` Shuah Khan
2015-03-12  3:11       ` Michael Ellerman
2015-03-12  3:15     ` Michael Ellerman
2015-03-13 16:33       ` Dave Jones
2015-03-13 17:08         ` Shuah Khan
2015-03-13 17:20   ` Shuah Khan
2015-03-13 21:32     ` Shuah Khan
2015-03-13 23:08       ` Shuah Khan
2015-03-16  3:04       ` Michael Ellerman
2015-03-16  3:12         ` Michael Ellerman
2015-03-18 14:30         ` Shuah Khan
2015-03-11  4:06 ` [PATCH v4 5/9] selftests: Add install support for the powerpc tests Michael Ellerman
2015-03-11  4:06 ` [PATCH v4 6/9] selftests: Set CC using CROSS_COMPILE once in lib.mk Michael Ellerman
2015-03-11  4:06 ` [PATCH v4 7/9] selftests/timers: Use implicit rules Michael Ellerman
2015-03-11  4:06 ` Michael Ellerman [this message]
2015-03-11  4:06 ` [PATCH v4 9/9] selftests/mount: " Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426046765-19289-8-git-send-email-mpe@ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=shuahkh@osg.samsung.com \
    --subject='Re: [PATCH v4 8/9] selftests/mqueue: Use implicit rules' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).