LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 15/15] iscsi-target: don't export static symbol
Date: Fri, 20 Mar 2015 11:42:12 -0700	[thread overview]
Message-ID: <1426876932.16687.5.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <1426092997-30605-16-git-send-email-Julia.Lawall@lip6.fr>

On Wed, 2015-03-11 at 17:56 +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
> 
> static T f (...) { ... }
> 
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
> 
> -EXPORT_SYMBOL(f);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
>  drivers/target/iscsi/iscsi_target.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff -u -p a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -2155,7 +2155,6 @@ reject:
>  	cmd->text_in_ptr = NULL;
>  	return iscsit_reject_cmd(cmd, ISCSI_REASON_PROTOCOL_ERROR, buf);
>  }
> -EXPORT_SYMBOL(iscsit_handle_text_cmd);
>  
>  int iscsit_logout_closesession(struct iscsi_cmd *cmd, struct iscsi_conn *conn)
>  {
> 

Applied to target-pending/for-next.

Thanks Julia!

--nab



      reply	other threads:[~2015-03-20 18:43 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 16:56 [PATCH 0/15] don't export static symbol Julia Lawall
2015-03-11 16:56 ` [PATCH 1/15] NFSv4.1: " Julia Lawall
2015-03-12 15:59   ` Trond Myklebust
2015-03-11 16:56 ` [PATCH 2/15] powerpc: " Julia Lawall
2015-03-11 16:56 ` [PATCH 3/15] net/mlx5_core: " Julia Lawall
2015-03-12  4:04   ` David Miller
2015-03-11 16:56 ` [PATCH 4/15] crypto: " Julia Lawall
2015-03-13 10:38   ` Herbert Xu
2015-03-11 16:56 ` [PATCH 5/15] clockevents: " Julia Lawall
2015-03-11 16:56 ` [PATCH 6/15] torture: " Julia Lawall
2015-03-11 16:56 ` [PATCH 7/15] media: pci: cx23885: " Julia Lawall
2015-03-11 16:56 ` [PATCH 8/15] libertas_tf: if_usb.c: " Julia Lawall
2015-03-13 14:18   ` [8/15] " Kalle Valo
2015-03-11 16:56 ` [PATCH 9/15] clk: " Julia Lawall
2015-03-12  6:03   ` Stephen Boyd
2015-03-11 16:56 ` [PATCH 10/15] scsi: " Julia Lawall
2015-03-11 16:56 ` [PATCH 11/15] ASoC: ab8500-codec: " Julia Lawall
2015-03-11 18:29   ` Mark Brown
2015-03-11 16:56 ` [PATCH 12/15] i82443bxgx_edac: " Julia Lawall
2015-03-11 19:48   ` Borislav Petkov
2015-03-11 16:56 ` [PATCH 13/15] ieee802154: " Julia Lawall
2015-03-11 18:17   ` Alexander Aring
2015-03-14 16:13   ` Marcel Holtmann
2015-03-11 16:56 ` [PATCH 14/15] ARM: cns3xxx: " Julia Lawall
2015-03-11 21:09   ` Arnd Bergmann
2015-03-13  5:59     ` Krzysztof Hałasa
2015-03-13 10:04       ` Arnd Bergmann
2015-03-11 16:56 ` [PATCH 15/15] iscsi-target: " Julia Lawall
2015-03-20 18:42   ` Nicholas A. Bellinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426876932.16687.5.camel@haakon3.risingtidesystems.com \
    --to=nab@linux-iscsi.org \
    --cc=Julia.Lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).