From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751560AbbCTSnF (ORCPT ); Fri, 20 Mar 2015 14:43:05 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:54062 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbbCTSmN (ORCPT ); Fri, 20 Mar 2015 14:42:13 -0400 Message-ID: <1426876932.16687.5.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH 15/15] iscsi-target: don't export static symbol From: "Nicholas A. Bellinger" To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 20 Mar 2015 11:42:12 -0700 In-Reply-To: <1426092997-30605-16-git-send-email-Julia.Lawall@lip6.fr> References: <1426092997-30605-1-git-send-email-Julia.Lawall@lip6.fr> <1426092997-30605-16-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-03-11 at 17:56 +0100, Julia Lawall wrote: > From: Julia Lawall > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @r@ > type T; > identifier f; > @@ > > static T f (...) { ... } > > @@ > identifier r.f; > declarer name EXPORT_SYMBOL; > @@ > > -EXPORT_SYMBOL(f); > // > > Signed-off-by: Julia Lawall > > --- > drivers/target/iscsi/iscsi_target.c | 1 - > 1 file changed, 1 deletion(-) > > diff -u -p a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c > --- a/drivers/target/iscsi/iscsi_target.c > +++ b/drivers/target/iscsi/iscsi_target.c > @@ -2155,7 +2155,6 @@ reject: > cmd->text_in_ptr = NULL; > return iscsit_reject_cmd(cmd, ISCSI_REASON_PROTOCOL_ERROR, buf); > } > -EXPORT_SYMBOL(iscsit_handle_text_cmd); > > int iscsit_logout_closesession(struct iscsi_cmd *cmd, struct iscsi_conn *conn) > { > Applied to target-pending/for-next. Thanks Julia! --nab