LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Peter Griffin <peter.griffin@linaro.org>
To: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com,
	maxime.coquelin@st.com, patrice.chotard@st.com, kishon@ti.com,
	balbi@ti.com
Cc: peter.griffin@linaro.org, lee.jones@linaro.org,
	devicetree@vger.kernel.org, robherring2@gmail.com
Subject: [PATCH v2 2/6] ahci: st: Update the DT example for how to obtain the PHY.
Date: Mon, 30 Mar 2015 16:17:08 +0100	[thread overview]
Message-ID: <1427728632-10846-3-git-send-email-peter.griffin@linaro.org> (raw)
In-Reply-To: <1427728632-10846-1-git-send-email-peter.griffin@linaro.org>

The example is wrong in that the phys property should take a
phandle to the phy port.

Also with the changing over to generic PHY type constants we also
update that as well.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Lee Jones <lee.jones@linaro.org>
---
 Documentation/devicetree/bindings/ata/ahci-st.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/ata/ahci-st.txt b/Documentation/devicetree/bindings/ata/ahci-st.txt
index 0574a77..1331202 100644
--- a/Documentation/devicetree/bindings/ata/ahci-st.txt
+++ b/Documentation/devicetree/bindings/ata/ahci-st.txt
@@ -11,7 +11,7 @@ Required properties:
  - reset-names	   :   Associated names must be; "pwr-dwn" and "sw-rst"
  - clocks	   : The phandle for the clock
  - clock-names	   :   Associated name must be; "ahci_clk"
- - phys		   : The phandle for the PHY device
+ - phys		   : The phandle for the PHY port
  - phy-names	   :   Associated name must be; "ahci_phy"
 
 Example:
@@ -21,7 +21,7 @@ Example:
 		reg             = <0xfe380000 0x1000>;
 		interrupts      = <GIC_SPI 157 IRQ_TYPE_NONE>;
 		interrupt-names = "hostc";
-		phys	        = <&miphy365x_phy MIPHY_PORT_0 MIPHY_TYPE_SATA>;
+		phys	        = <&phy_port0 PHY_TYPE_SATA>;
 		phy-names       = "ahci_phy";
 		resets	        = <&powerdown STIH416_SATA0_POWERDOWN>,
 				  <&softreset STIH416_SATA0_SOFTRESET>;
-- 
1.9.1


  parent reply	other threads:[~2015-03-30 15:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 15:17 [PATCH v2 0/6] Add dwc3 usb3 DT node and various phy cleanup Peter Griffin
2015-03-30 15:17 ` [PATCH v2 1/6] phy: miphy365x: Use the generic phy type constants in dt-bindings/phy/phy.h Peter Griffin
2015-03-31  5:14   ` Kishon Vijay Abraham I
2015-03-31  7:40     ` Lee Jones
2015-03-31  8:01       ` Peter Griffin
2015-03-31  8:47         ` Lee Jones
2015-03-31 15:30       ` Kishon Vijay Abraham I
2015-03-31 15:55         ` Maxime Coquelin
2015-04-01  7:15           ` Lee Jones
2015-04-01  8:01             ` Kishon Vijay Abraham I
2015-04-01 11:42               ` Lee Jones
2015-03-30 15:17 ` Peter Griffin [this message]
2015-03-30 15:17 ` [PATCH v2 3/6] ARM: DT: STi: STiH407: Update picophyreset for the usb3 controllers usb2 phy Peter Griffin
2015-03-30 15:17 ` [PATCH v2 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node Peter Griffin
2015-03-30 15:17 ` [PATCH v2 5/6] usb: dwc3: dwc3-st: Update the incorrect DT dwc3 example Peter Griffin
2015-03-30 15:17 ` [PATCH v2 6/6] MAINTAINERS: Add phy-miphy28lp.c to ARCH/STI architecture Peter Griffin
2015-03-31 16:15   ` Kishon Vijay Abraham I
2015-03-31 17:40     ` Peter Griffin
2015-04-01  5:57       ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427728632-10846-3-git-send-email-peter.griffin@linaro.org \
    --to=peter.griffin@linaro.org \
    --cc=balbi@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.coquelin@st.com \
    --cc=patrice.chotard@st.com \
    --cc=robherring2@gmail.com \
    --cc=srinivas.kandagatla@gmail.com \
    --subject='Re: [PATCH v2 2/6] ahci: st: Update the DT example for how to obtain the PHY.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).