LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/1 linux-next] Btrfs: use BTRFS_COMPRESS_NONE instead of 0
@ 2015-03-30 20:21 Fabian Frederick
  2015-03-31 14:28 ` David Sterba
  0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2015-03-30 20:21 UTC (permalink / raw)
  To: linux-kernel
  Cc: Fabian Frederick, Chris Mason, Josef Bacik, David Sterba, linux-btrfs

cow_file_range_inline() was called with 0 instead of
actual definition.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 fs/btrfs/inode.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 686331f..f626519 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -524,7 +524,8 @@ cont:
 			 * to make an uncompressed inline extent.
 			 */
 			ret = cow_file_range_inline(root, inode, start, end,
-						    0, 0, NULL);
+						    0, BTRFS_COMPRESS_NONE,
+						    NULL);
 		} else {
 			/* try making a compressed inline extent */
 			ret = cow_file_range_inline(root, inode, start, end,
@@ -943,8 +944,8 @@ static noinline int cow_file_range(struct inode *inode,
 
 	if (start == 0) {
 		/* lets try to make an inline extent */
-		ret = cow_file_range_inline(root, inode, start, end, 0, 0,
-					    NULL);
+		ret = cow_file_range_inline(root, inode, start, end, 0,
+					    BTRFS_COMPRESS_NONE, NULL);
 		if (ret == 0) {
 			extent_clear_unlock_delalloc(inode, start, end, NULL,
 				     EXTENT_LOCKED | EXTENT_DELALLOC |
-- 
1.9.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1 linux-next] Btrfs: use BTRFS_COMPRESS_NONE instead of 0
  2015-03-30 20:21 [PATCH 1/1 linux-next] Btrfs: use BTRFS_COMPRESS_NONE instead of 0 Fabian Frederick
@ 2015-03-31 14:28 ` David Sterba
  0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2015-03-31 14:28 UTC (permalink / raw)
  To: Fabian Frederick; +Cc: linux-kernel, Chris Mason, Josef Bacik, linux-btrfs

On Mon, Mar 30, 2015 at 10:21:11PM +0200, Fabian Frederick wrote:
> cow_file_range_inline() was called with 0 instead of
> actual definition.

Please also fix the initialization in btrfs_finish_ordered_io .

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-31 14:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-30 20:21 [PATCH 1/1 linux-next] Btrfs: use BTRFS_COMPRESS_NONE instead of 0 Fabian Frederick
2015-03-31 14:28 ` David Sterba

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).