LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] ramoops: make it possible to change mem_type param.
@ 2015-03-31  1:33 Wang Long
  2015-04-02 14:19 ` Mark Salyzyn
  0 siblings, 1 reply; 4+ messages in thread
From: Wang Long @ 2015-03-31  1:33 UTC (permalink / raw)
  To: keescook, tony, ccross, tony.luck
  Cc: linux-kernel, long.wanglong, peifeiyue, morgan.wang, salyzyn,
	anton.vorontsov, marco.stornelli

If we set ramoops.mem_type=1 in command line, the current
code can not change mem_type to 1, because it is assigned
to 0 in function ramoops_register_dummy.

This patch make it possible to change mem_type parameter
in command line.

Signed-off-by: Wang Long <long.wanglong@huawei.com>
Acked-by: Tony Lindgren <tony@atomide.com>
---
 fs/pstore/ram.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 44a549b..4449653 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -608,7 +608,7 @@ static void ramoops_register_dummy(void)
 
 	dummy_data->mem_size = mem_size;
 	dummy_data->mem_address = mem_address;
-	dummy_data->mem_type = 0;
+	dummy_data->mem_type = mem_type;
 	dummy_data->record_size = record_size;
 	dummy_data->console_size = ramoops_console_size;
 	dummy_data->ftrace_size = ramoops_ftrace_size;
-- 
1.8.3.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ramoops: make it possible to change mem_type param.
  2015-03-31  1:33 [PATCH v2] ramoops: make it possible to change mem_type param Wang Long
@ 2015-04-02 14:19 ` Mark Salyzyn
  2015-04-02 17:10   ` marco
  0 siblings, 1 reply; 4+ messages in thread
From: Mark Salyzyn @ 2015-04-02 14:19 UTC (permalink / raw)
  To: Wang Long, keescook, tony, ccross, tony.luck
  Cc: linux-kernel, peifeiyue, morgan.wang, anton.vorontsov, marco.stornelli

On 03/30/2015 06:33 PM, Wang Long wrote:
>   	dummy_data->mem_size = mem_size;
>   	dummy_data->mem_address = mem_address;
> -	dummy_data->mem_type = 0;
> +	dummy_data->mem_type = mem_type;
>   	dummy_data->record_size = record_size;
>   	dummy_data->console_size = ramoops_console_size;
>   	dummy_data->ftrace_size = ramoops_ftrace_size;
Ack

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ramoops: make it possible to change mem_type param.
  2015-04-02 14:19 ` Mark Salyzyn
@ 2015-04-02 17:10   ` marco
  2015-05-04  9:25     ` long.wanglong
  0 siblings, 1 reply; 4+ messages in thread
From: marco @ 2015-04-02 17:10 UTC (permalink / raw)
  To: Mark Salyzyn, Wang Long, keescook, tony, ccross, tony.luck
  Cc: linux-kernel, peifeiyue, morgan.wang, anton.vorontsov

> On 03/30/2015 06:33 PM, Wang Long wrote:
>>       dummy_data->mem_size = mem_size;
>>       dummy_data->mem_address = mem_address;
>> -    dummy_data->mem_type = 0;
>> +    dummy_data->mem_type = mem_type;
>>       dummy_data->record_size = record_size;
>>       dummy_data->console_size = ramoops_console_size;
>>       dummy_data->ftrace_size = ramoops_ftrace_size;
> Ack

Acked-by: Marco Stornelli <marco.stornelli@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ramoops: make it possible to change mem_type param.
  2015-04-02 17:10   ` marco
@ 2015-05-04  9:25     ` long.wanglong
  0 siblings, 0 replies; 4+ messages in thread
From: long.wanglong @ 2015-05-04  9:25 UTC (permalink / raw)
  To: Tony Luck
  Cc: Mark Salyzyn, keescook, tony, ccross, linux-kernel, peifeiyue,
	morgan.wang, anton.vorontsov

On 2015/4/3 1:10, marco wrote:
>> On 03/30/2015 06:33 PM, Wang Long wrote:
>>>       dummy_data->mem_size = mem_size;
>>>       dummy_data->mem_address = mem_address;
>>> -    dummy_data->mem_type = 0;
>>> +    dummy_data->mem_type = mem_type;
>>>       dummy_data->record_size = record_size;
>>>       dummy_data->console_size = ramoops_console_size;
>>>       dummy_data->ftrace_size = ramoops_ftrace_size;
>> Ack
> 
> Acked-by: Marco Stornelli <marco.stornelli@gmail.com>
> 
> .
> 

Hi Tony Luck,

Could you please help to commit this patch?

Thank you.

Best Regards
Wang Long


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-05-04 10:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-31  1:33 [PATCH v2] ramoops: make it possible to change mem_type param Wang Long
2015-04-02 14:19 ` Mark Salyzyn
2015-04-02 17:10   ` marco
2015-05-04  9:25     ` long.wanglong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).