LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Robert Baldyga <r.baldyga@samsung.com>
To: cw00.choi@samsung.com
Cc: myungjoo.ham@samsung.com, rogerq@ti.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	m.szyprowski@samsung.com, Robert Baldyga <r.baldyga@samsung.com>
Subject: [PATCH 3/4] extcon: usb-gpio: make debounce value configurable in devicetree
Date: Tue, 31 Mar 2015 09:46:02 +0200	[thread overview]
Message-ID: <1427787963-23562-4-git-send-email-r.baldyga@samsung.com> (raw)
In-Reply-To: <1427787963-23562-1-git-send-email-r.baldyga@samsung.com>

This patch adds devicetree property for setting debounce value. It allows
to set debounce time shorter or longer depending on the needs of given
platform.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
---
 drivers/extcon/extcon-usb-gpio.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
index 02ff40e..86e3ece 100644
--- a/drivers/extcon/extcon-usb-gpio.c
+++ b/drivers/extcon/extcon-usb-gpio.c
@@ -130,6 +130,7 @@ static int usb_extcon_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct device_node *np = dev->of_node;
 	struct usb_extcon_info *info;
+	u32 debounce;
 	int ret;
 
 	if (!np)
@@ -140,6 +141,11 @@ static int usb_extcon_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	info->dev = dev;
+
+	ret = of_property_read_u32(np, "debounce", &debounce);
+	if (ret < 0)
+		debounce = USB_GPIO_DEBOUNCE_MS;
+
 	info->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
 	info->vbus_gpiod = devm_gpiod_get_optional(&pdev->dev, "vbus");
 
@@ -161,16 +167,14 @@ static int usb_extcon_probe(struct platform_device *pdev)
 	}
 
 	if (info->id_gpiod)
-		ret = gpiod_set_debounce(info->id_gpiod,
-			USB_GPIO_DEBOUNCE_MS * 1000);
+		ret = gpiod_set_debounce(info->id_gpiod, debounce * 1000);
 	if (!ret && info->vbus_gpiod) {
-		ret = gpiod_set_debounce(info->vbus_gpiod,
-			USB_GPIO_DEBOUNCE_MS * 1000);
+		ret = gpiod_set_debounce(info->vbus_gpiod, debounce * 1000);
 		if (ret < 0 && info->id_gpiod)
 			gpiod_set_debounce(info->vbus_gpiod, 0);
 	}
 	if (ret < 0)
-		info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEBOUNCE_MS);
+		info->debounce_jiffies = msecs_to_jiffies(debounce);
 
 	INIT_DELAYED_WORK(&info->wq_detcable, usb_extcon_detect_cable);
 
-- 
1.9.1


  parent reply	other threads:[~2015-03-31  7:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-31  7:45 [PATCH 0/4] extcon: usb-gpio: fixes and improvements Robert Baldyga
2015-03-31  7:46 ` [PATCH 1/4] extcon: usb-gpio: register extcon device before IRQ registration Robert Baldyga
2015-03-31  8:37   ` Roger Quadros
2015-03-31  7:46 ` [PATCH 2/4] extcon: usb-gpio: add support for VBUS detection Robert Baldyga
2015-03-31  9:22   ` Roger Quadros
2015-03-31  7:46 ` Robert Baldyga [this message]
2015-03-31  9:30   ` [PATCH 3/4] extcon: usb-gpio: make debounce value configurable in devicetree Roger Quadros
2015-03-31 12:16     ` Robert Baldyga
2015-03-31  7:46 ` [PATCH 4/4] Documentation: extcon: usb-gpio: update usb-gpio binding description Robert Baldyga
2015-03-31 10:20   ` Roger Quadros
2015-03-31 12:04     ` Robert Baldyga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427787963-23562-4-git-send-email-r.baldyga@samsung.com \
    --to=r.baldyga@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=rogerq@ti.com \
    --subject='Re: [PATCH 3/4] extcon: usb-gpio: make debounce value configurable in devicetree' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).