LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1
@ 2015-03-31  8:56 Nicolas Ferre
  2015-04-03  8:43 ` Nicolas Ferre
  0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Ferre @ 2015-03-31  8:56 UTC (permalink / raw)
  To: linux-arm-kernel, netdev
  Cc: linux-kernel, Boris BREZILLON, Alexandre Belloni, Nicolas Ferre,
	Johan Hovold, stable

After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091)
the macb1 interface refuses to work properly because it tries
to cling to address 0 which isn't able to communicate in broadcast with
the mac anymore. The micrel phy on the board is actually configured
to show up at address 1.
Adding the phy node and its real address fixes the issue.

Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Johan Hovold <johan@kernel.org>
Cc: <stable@vger.kernel.org> #3.19
---
 arch/arm/boot/dts/at91-sama5d3_xplained.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
index fec1fca2ad66..6c4bc53cbf4e 100644
--- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
@@ -167,7 +167,13 @@
 
 			macb1: ethernet@f802c000 {
 				phy-mode = "rmii";
+				#address-cells = <1>;
+				#size-cells = <0>;
 				status = "okay";
+
+				ethernet-phy@1 {
+					reg = <0x1>;
+				};
 			};
 
 			dbgu: serial@ffffee00 {
-- 
2.1.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1
  2015-03-31  8:56 [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1 Nicolas Ferre
@ 2015-04-03  8:43 ` Nicolas Ferre
  2015-04-03 20:55   ` Olof Johansson
  0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Ferre @ 2015-04-03  8:43 UTC (permalink / raw)
  To: linux-arm-kernel, Arnd Bergmann, Olof Johansson, Kevin Hilman,
	ARM Maintainers
  Cc: netdev, linux-kernel, Boris BREZILLON, Alexandre Belloni,
	Johan Hovold, stable

Le 31/03/2015 10:56, Nicolas Ferre a écrit :
> After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091)
> the macb1 interface refuses to work properly because it tries
> to cling to address 0 which isn't able to communicate in broadcast with
> the mac anymore. The micrel phy on the board is actually configured
> to show up at address 1.
> Adding the phy node and its real address fixes the issue.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Johan Hovold <johan@kernel.org>
> Cc: <stable@vger.kernel.org> #3.19
> ---

Arnd, Olof, Kevin,

It seems late but, is it possible to queue this patch as a 4.0 fixes?

Without it, the 10/100 Ethernet on sama5d3 doesn't work if it's not used
by u-boot previously.

Bye,

>  arch/arm/boot/dts/at91-sama5d3_xplained.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> index fec1fca2ad66..6c4bc53cbf4e 100644
> --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> @@ -167,7 +167,13 @@
>  
>  			macb1: ethernet@f802c000 {
>  				phy-mode = "rmii";
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				status = "okay";
> +
> +				ethernet-phy@1 {
> +					reg = <0x1>;
> +				};
>  			};
>  
>  			dbgu: serial@ffffee00 {
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1
  2015-04-03  8:43 ` Nicolas Ferre
@ 2015-04-03 20:55   ` Olof Johansson
  2015-04-03 21:56     ` Olof Johansson
  0 siblings, 1 reply; 5+ messages in thread
From: Olof Johansson @ 2015-04-03 20:55 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: linux-arm-kernel, Arnd Bergmann, Kevin Hilman, ARM Maintainers,
	netdev, linux-kernel, Boris BREZILLON, Alexandre Belloni,
	Johan Hovold, stable

On Fri, Apr 03, 2015 at 10:43:40AM +0200, Nicolas Ferre wrote:
> Le 31/03/2015 10:56, Nicolas Ferre a écrit :
> > After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091)
> > the macb1 interface refuses to work properly because it tries
> > to cling to address 0 which isn't able to communicate in broadcast with
> > the mac anymore. The micrel phy on the board is actually configured
> > to show up at address 1.
> > Adding the phy node and its real address fixes the issue.
> > 
> > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> > Cc: Johan Hovold <johan@kernel.org>
> > Cc: <stable@vger.kernel.org> #3.19
> > ---
> 
> Arnd, Olof, Kevin,
> 
> It seems late but, is it possible to queue this patch as a 4.0 fixes?
> 
> Without it, the 10/100 Ethernet on sama5d3 doesn't work if it's not used
> by u-boot previously.

Sure, resend it to arm@kernel.org.


-Olof

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1
  2015-04-03 20:55   ` Olof Johansson
@ 2015-04-03 21:56     ` Olof Johansson
  2015-04-04 12:45       ` Nicolas Ferre
  0 siblings, 1 reply; 5+ messages in thread
From: Olof Johansson @ 2015-04-03 21:56 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: linux-arm-kernel, Arnd Bergmann, Kevin Hilman, ARM Maintainers,
	netdev, linux-kernel, Boris BREZILLON, Alexandre Belloni,
	Johan Hovold, stable

On Fri, Apr 03, 2015 at 01:55:07PM -0700, Olof Johansson wrote:
> On Fri, Apr 03, 2015 at 10:43:40AM +0200, Nicolas Ferre wrote:
> > Le 31/03/2015 10:56, Nicolas Ferre a écrit :
> > > After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091)
> > > the macb1 interface refuses to work properly because it tries
> > > to cling to address 0 which isn't able to communicate in broadcast with
> > > the mac anymore. The micrel phy on the board is actually configured
> > > to show up at address 1.
> > > Adding the phy node and its real address fixes the issue.
> > > 
> > > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> > > Cc: Johan Hovold <johan@kernel.org>
> > > Cc: <stable@vger.kernel.org> #3.19
> > > ---
> > 
> > Arnd, Olof, Kevin,
> > 
> > It seems late but, is it possible to queue this patch as a 4.0 fixes?
> > 
> > Without it, the 10/100 Ethernet on sama5d3 doesn't work if it's not used
> > by u-boot previously.
> 
> Sure, resend it to arm@kernel.org.

Nevermind, I ended up picking it up from the list. Applied.


-Olof

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1
  2015-04-03 21:56     ` Olof Johansson
@ 2015-04-04 12:45       ` Nicolas Ferre
  0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Ferre @ 2015-04-04 12:45 UTC (permalink / raw)
  To: Olof Johansson
  Cc: linux-arm-kernel, Arnd Bergmann, Kevin Hilman, ARM Maintainers,
	netdev, linux-kernel, Boris BREZILLON, Alexandre Belloni,
	Johan Hovold, stable

Le 03/04/2015 23:56, Olof Johansson a écrit :
> On Fri, Apr 03, 2015 at 01:55:07PM -0700, Olof Johansson wrote:
>> On Fri, Apr 03, 2015 at 10:43:40AM +0200, Nicolas Ferre wrote:
>>> Le 31/03/2015 10:56, Nicolas Ferre a écrit :
>>>> After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091)
>>>> the macb1 interface refuses to work properly because it tries
>>>> to cling to address 0 which isn't able to communicate in broadcast with
>>>> the mac anymore. The micrel phy on the board is actually configured
>>>> to show up at address 1.
>>>> Adding the phy node and its real address fixes the issue.
>>>>
>>>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>>>> Cc: Johan Hovold <johan@kernel.org>
>>>> Cc: <stable@vger.kernel.org> #3.19
>>>> ---
>>>
>>> Arnd, Olof, Kevin,
>>>
>>> It seems late but, is it possible to queue this patch as a 4.0 fixes?
>>>
>>> Without it, the 10/100 Ethernet on sama5d3 doesn't work if it's not used
>>> by u-boot previously.
>>
>> Sure, resend it to arm@kernel.org.
>
> Nevermind, I ended up picking it up from the list. Applied.

Cool: thanks Olof!

Bye,

-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-04-04 12:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-31  8:56 [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1 Nicolas Ferre
2015-04-03  8:43 ` Nicolas Ferre
2015-04-03 20:55   ` Olof Johansson
2015-04-03 21:56     ` Olof Johansson
2015-04-04 12:45       ` Nicolas Ferre

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).