LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Phong Tran <tranmanphong@gmail.com>
To: gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Phong Tran <tranmanphong@gmail.com>
Subject: [PATCH 2/3] staging: android: ion_test: unregister the misc device
Date: Thu,  2 Apr 2015 00:38:19 +0700	[thread overview]
Message-ID: <1427909900-22650-3-git-send-email-tranmanphong@gmail.com> (raw)
In-Reply-To: <1427909900-22650-1-git-send-email-tranmanphong@gmail.com>

Add the remove() method for deregister from misc device
when it's unloaded.

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
---
 drivers/staging/android/ion/ion_test.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/staging/android/ion/ion_test.c b/drivers/staging/android/ion/ion_test.c
index 3bc461c..f36a35e 100644
--- a/drivers/staging/android/ion/ion_test.c
+++ b/drivers/staging/android/ion/ion_test.c
@@ -261,7 +261,25 @@ static int __init ion_test_probe(struct platform_device *pdev)
 	return 0;
 }
 
+static int ion_test_remove(struct platform_device *pdev)
+{
+	int ret = 0;
+	struct ion_test_device *testdev;
+
+	testdev = platform_get_drvdata(pdev);
+
+	if (!testdev) {
+		pr_err("failed to get pdev data.\n");
+		return -ENODATA;
+	}
+
+	ret = misc_deregister(&testdev->misc);
+
+	return ret;
+}
+
 static struct platform_driver ion_test_platform_driver = {
+	.remove = ion_test_remove,
 	.driver = {
 		.name = "ion-test",
 	},
-- 
2.1.0


  parent reply	other threads:[~2015-04-01 17:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 17:38 [PATCH 0/3] Fix some issues of staging ion test driver Phong Tran
2015-04-01 17:38 ` [PATCH 1/3] staging: android: ion_test: Add the MODULE_LICENSE macro Phong Tran
2015-04-01 17:38 ` Phong Tran [this message]
2015-04-01 22:22   ` [PATCH 2/3] staging: android: ion_test: unregister the misc device Dan Carpenter
2015-04-01 17:38 ` [PATCH 3/3] staging: android: ion_test: unregister the platform device Phong Tran
2015-04-01 22:34   ` Dan Carpenter
2015-04-02 14:36   ` [PATCH V2 0/3] Fix some issues of staging ion test driver Phong Tran
2015-04-02 14:36     ` [PATCH V2 1/3] staging: android: ion_test: Add the MODULE_LICENSE macro Phong Tran
2015-04-02 14:36     ` [PATCH V2 2/3] staging: android: ion_test: unregister the misc device Phong Tran
2015-04-03 13:13       ` Greg KH
2015-04-03 14:07         ` [PATCH V3 0/2] Fix some issues of staging ion test driver Phong Tran
2015-04-03 14:07           ` [PATCH V3 1/2] staging: android: ion_test: unregister the misc device Phong Tran
2015-04-03 14:07           ` [PATCH V3 2/2] staging: android: ion_test: unregister the platform device Phong Tran
2015-04-02 14:36     ` [PATCH V2 3/3] " Phong Tran
2015-04-02 15:22     ` [PATCH V2 0/3] Fix some issues of staging ion test driver Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427909900-22650-3-git-send-email-tranmanphong@gmail.com \
    --to=tranmanphong@gmail.com \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    --subject='Re: [PATCH 2/3] staging: android: ion_test: unregister the misc device' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).