LKML Archive on
help / color / mirror / Atom feed
From: Sudip Mukherjee <>
To: Greg Kroah-Hartman <>,
	"Lad, Prabhakar" <>
Cc: Sudip Mukherjee <>,,
Subject: [PATCH] Revert "usb: host/sl811-hcd: fix sparse warning"
Date: Thu,  2 Apr 2015 16:45:40 +0530	[thread overview]
Message-ID: <> (raw)

This reverts commit <1dc6120ef7f003305d99ef12f598a6b05eacc38c>.

if we are doing allyesconfig on x86_64, build fails with error:
drivers/built-in.o: In function `sl811_cs_probe':
sl811_cs.c:(.text+0x1d4612e): undefined reference to `sl811h_driver'

this commit has declared sl811h_driver as static but it was being
accessed from sl811_cs.c.

Signed-off-by: Sudip Mukherjee <>
 drivers/usb/host/sl811-hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/sl811-hcd.c b/drivers/usb/host/sl811-hcd.c
index 944a417..f1d5c5a 100644
--- a/drivers/usb/host/sl811-hcd.c
+++ b/drivers/usb/host/sl811-hcd.c
@@ -1801,7 +1801,7 @@ sl811h_resume(struct platform_device *dev)
 /* this driver is exported so sl811_cs can depend on it */
-static struct platform_driver sl811h_driver = {
+struct platform_driver sl811h_driver = {
 	.probe =	sl811h_probe,
 	.remove =	sl811h_remove,

             reply	other threads:[~2015-04-02 11:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02 11:15 Sudip Mukherjee [this message]
2015-04-03 13:44 ` [PATCH] Revert "usb: host/sl811-hcd: fix sparse warning" Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).