LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH RESEND] mfd: arizona: Remove redundant register sync
@ 2015-04-22 13:34 Charles Keepax
  2015-04-29 10:55 ` Lee Jones
  0 siblings, 1 reply; 2+ messages in thread
From: Charles Keepax @ 2015-04-22 13:34 UTC (permalink / raw)
  To: lee.jones; +Cc: sameo, patches, linux-kernel

This soft reset used to be located after the register patch had been
applied, but has since moved to before the patch is applied. At the new
location there is no requirement to do a register sync as no register
writes will have happened yet.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
 drivers/mfd/arizona-core.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index 6ca6dfa..aed43a5 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -777,8 +777,6 @@ int arizona_dev_init(struct arizona *arizona)
 
 	/* If we have a /RESET GPIO we'll already be reset */
 	if (!arizona->pdata.reset) {
-		regcache_mark_dirty(arizona->regmap);
-
 		ret = regmap_write(arizona->regmap, ARIZONA_SOFTWARE_RESET, 0);
 		if (ret != 0) {
 			dev_err(dev, "Failed to reset device: %d\n", ret);
@@ -786,12 +784,6 @@ int arizona_dev_init(struct arizona *arizona)
 		}
 
 		msleep(1);
-
-		ret = regcache_sync(arizona->regmap);
-		if (ret != 0) {
-			dev_err(dev, "Failed to sync device: %d\n", ret);
-			goto err_reset;
-		}
 	}
 
 	/* Ensure device startup is complete */
-- 
1.7.2.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH RESEND] mfd: arizona: Remove redundant register sync
  2015-04-22 13:34 [PATCH RESEND] mfd: arizona: Remove redundant register sync Charles Keepax
@ 2015-04-29 10:55 ` Lee Jones
  0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2015-04-29 10:55 UTC (permalink / raw)
  To: Charles Keepax; +Cc: sameo, patches, linux-kernel

On Wed, 22 Apr 2015, Charles Keepax wrote:

> This soft reset used to be located after the register patch had been
> applied, but has since moved to before the patch is applied. At the new
> location there is no requirement to do a register sync as no register
> writes will have happened yet.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>  drivers/mfd/arizona-core.c |    8 --------
>  1 files changed, 0 insertions(+), 8 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 6ca6dfa..aed43a5 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -777,8 +777,6 @@ int arizona_dev_init(struct arizona *arizona)
>  
>  	/* If we have a /RESET GPIO we'll already be reset */
>  	if (!arizona->pdata.reset) {
> -		regcache_mark_dirty(arizona->regmap);
> -
>  		ret = regmap_write(arizona->regmap, ARIZONA_SOFTWARE_RESET, 0);
>  		if (ret != 0) {
>  			dev_err(dev, "Failed to reset device: %d\n", ret);
> @@ -786,12 +784,6 @@ int arizona_dev_init(struct arizona *arizona)
>  		}
>  
>  		msleep(1);
> -
> -		ret = regcache_sync(arizona->regmap);
> -		if (ret != 0) {
> -			dev_err(dev, "Failed to sync device: %d\n", ret);
> -			goto err_reset;
> -		}
>  	}
>  
>  	/* Ensure device startup is complete */

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-29 10:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-22 13:34 [PATCH RESEND] mfd: arizona: Remove redundant register sync Charles Keepax
2015-04-29 10:55 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).