LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
	Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: "Ulrich Ölmann" <u.oelmann@pengutronix.de>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Sam Ravnborg" <sam@ravnborg.org>
Subject: Re: [PATCH v1 1/2] drm/panel: simple: add Multi-Innotechnology MI1010AIT-1CP1
Date: Thu, 5 Aug 2021 07:52:24 +0200	[thread overview]
Message-ID: <1462f001-a01f-9634-744c-8981f72663f6@pengutronix.de> (raw)
In-Reply-To: <20210805043702.24715-1-o.rempel@pengutronix.de>

Hello Oleksij,

On 05.08.21 06:37, Oleksij Rempel wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
> 
> The Multi Innotechnology is a 10.1" 1280x800 panel.
> 
> The datasheet did not specify specific values for sync, back, front porch.
> The values are a best guess based on values for similar panels.
> 
> Co-Developed-by: Sam Ravnborg <sam@ravnborg.org>
> Co-Developed-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 21939d4352cf..fda79a986d12 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3033,6 +3033,37 @@ static const struct panel_desc mitsubishi_aa070mc01 = {
>  	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
>  };
>  
> +static const struct display_timing multi_inno_mi1010ait_1cp_timing = {
> +	.pixelclock = { 68900000, 70000000, 73400000 },
> +	.hactive = { 1280, 1280, 1280 },
> +	.hfront_porch = { 30, 60, 71 },
> +	.hback_porch = { 30, 60, 71 },
> +	.hsync_len = { 10, 10, 48 },
> +	.vactive = { 800, 800, 800 },
> +	.vfront_porch = { 5, 10, 10 },
> +	.vback_porch = { 5, 10, 10 },
> +	.vsync_len = { 5, 6, 13 },
> +	.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
> +		 DISPLAY_FLAGS_DE_HIGH,
> +};

Here you specify DISPLAY_FLAGS_DE_HIGH.

> +
> +static const struct panel_desc multi_inno_mi1010ait_1cp = {
> +	.timings = &multi_inno_mi1010ait_1cp_timing,
> +	.num_timings = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 217,
> +		.height = 136,
> +	},
> +	.delay = {
> +		.enable = 50,
> +		.disable = 50,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH,

And here DRM_BUS_FLAG_DE_HIGH. I see that some other panels do this too
and some only specify one of them. Do you know if they are redundant
or one of them is ignored?

Cheers,
Ahmad

> +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
> +};
> +
>  static const struct display_timing nec_nl12880bc20_05_timing = {
>  	.pixelclock = { 67000000, 71000000, 75000000 },
>  	.hactive = { 1280, 1280, 1280 },
> @@ -4464,6 +4495,9 @@ static const struct of_device_id platform_of_match[] = {
>  	}, {
>  		.compatible = "mitsubishi,aa070mc01-ca1",
>  		.data = &mitsubishi_aa070mc01,
> +	}, {
> +		.compatible = "multi-inno,mi1010ait-1cp",
> +		.data = &multi_inno_mi1010ait_1cp,
>  	}, {
>  		.compatible = "nec,nl12880bc20-05",
>  		.data = &nec_nl12880bc20_05,
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2021-08-05  5:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05  4:37 Oleksij Rempel
2021-08-05  4:37 ` [PATCH v1 2/2] drm/panel: simple: add LOGIC Technologies LTTD800480070-L6WH-RT Oleksij Rempel
2021-08-05  5:44   ` Ahmad Fatoum
2021-08-05  5:52 ` Ahmad Fatoum [this message]
2021-08-05 10:08   ` [PATCH v1 1/2] drm/panel: simple: add Multi-Innotechnology MI1010AIT-1CP1 Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462f001-a01f-9634-744c-8981f72663f6@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.oelmann@pengutronix.de \
    --subject='Re: [PATCH v1 1/2] drm/panel: simple: add Multi-Innotechnology MI1010AIT-1CP1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).