From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F697C4338F for ; Thu, 5 Aug 2021 05:53:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 798D160EBB for ; Thu, 5 Aug 2021 05:53:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235431AbhHEFw6 (ORCPT ); Thu, 5 Aug 2021 01:52:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229892AbhHEFwo (ORCPT ); Thu, 5 Aug 2021 01:52:44 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF8E9C061765 for ; Wed, 4 Aug 2021 22:52:29 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mBWIs-0002Qu-BG; Thu, 05 Aug 2021 07:52:26 +0200 Subject: Re: [PATCH v1 1/2] drm/panel: simple: add Multi-Innotechnology MI1010AIT-1CP1 To: Oleksij Rempel , Thierry Reding , David Airlie , Daniel Vetter Cc: =?UTF-8?Q?Ulrich_=c3=96lmann?= , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Pengutronix Kernel Team , Sam Ravnborg References: <20210805043702.24715-1-o.rempel@pengutronix.de> From: Ahmad Fatoum Message-ID: <1462f001-a01f-9634-744c-8981f72663f6@pengutronix.de> Date: Thu, 5 Aug 2021 07:52:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210805043702.24715-1-o.rempel@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Oleksij, On 05.08.21 06:37, Oleksij Rempel wrote: > From: Sam Ravnborg > > The Multi Innotechnology is a 10.1" 1280x800 panel. > > The datasheet did not specify specific values for sync, back, front porch. > The values are a best guess based on values for similar panels. > > Co-Developed-by: Sam Ravnborg > Co-Developed-by: Ulrich Ölmann > Signed-off-by: Sam Ravnborg > Signed-off-by: Ulrich Ölmann > Signed-off-by: Oleksij Rempel > --- > drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 21939d4352cf..fda79a986d12 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -3033,6 +3033,37 @@ static const struct panel_desc mitsubishi_aa070mc01 = { > .bus_flags = DRM_BUS_FLAG_DE_HIGH, > }; > > +static const struct display_timing multi_inno_mi1010ait_1cp_timing = { > + .pixelclock = { 68900000, 70000000, 73400000 }, > + .hactive = { 1280, 1280, 1280 }, > + .hfront_porch = { 30, 60, 71 }, > + .hback_porch = { 30, 60, 71 }, > + .hsync_len = { 10, 10, 48 }, > + .vactive = { 800, 800, 800 }, > + .vfront_porch = { 5, 10, 10 }, > + .vback_porch = { 5, 10, 10 }, > + .vsync_len = { 5, 6, 13 }, > + .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW | > + DISPLAY_FLAGS_DE_HIGH, > +}; Here you specify DISPLAY_FLAGS_DE_HIGH. > + > +static const struct panel_desc multi_inno_mi1010ait_1cp = { > + .timings = &multi_inno_mi1010ait_1cp_timing, > + .num_timings = 1, > + .bpc = 8, > + .size = { > + .width = 217, > + .height = 136, > + }, > + .delay = { > + .enable = 50, > + .disable = 50, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH, And here DRM_BUS_FLAG_DE_HIGH. I see that some other panels do this too and some only specify one of them. Do you know if they are redundant or one of them is ignored? Cheers, Ahmad > + .connector_type = DRM_MODE_CONNECTOR_LVDS, > +}; > + > static const struct display_timing nec_nl12880bc20_05_timing = { > .pixelclock = { 67000000, 71000000, 75000000 }, > .hactive = { 1280, 1280, 1280 }, > @@ -4464,6 +4495,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "mitsubishi,aa070mc01-ca1", > .data = &mitsubishi_aa070mc01, > + }, { > + .compatible = "multi-inno,mi1010ait-1cp", > + .data = &multi_inno_mi1010ait_1cp, > }, { > .compatible = "nec,nl12880bc20-05", > .data = &nec_nl12880bc20_05, > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |