LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-kselftest <linux-kselftest@vger.kernel.org>,
	shuah <shuah@kernel.org>
Subject: Re: [PATCH 1/1] selftests: Fix lib.mk run_tests target shell script
Date: Wed, 1 Nov 2017 22:22:52 +0000 (UTC)	[thread overview]
Message-ID: <1490563551.1701.1509574972486.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <44e3d6b0-6e0d-4482-fa7e-d8dac8619d4e@osg.samsung.com>

----- On Nov 1, 2017, at 5:33 PM, Shuah Khan shuahkh@osg.samsung.com wrote:

> On 10/28/2017 07:46 AM, Mathieu Desnoyers wrote:
>> Within run_tests target, the whole script needs to be executed within
>> the same shell and not as separate subshells, so the initial test_num
>> variable set to 0 is still present when executing "test_num=`echo
>> $$test_num+1 | bc`;".
>> 
>> Demonstration of the issue (make run_tests):
>> 
>> TAP version 13
>> (standard_in) 1: syntax error
>> selftests: basic_test
>> ========================================
>> ok 1.. selftests: basic_test [PASS]
>> (standard_in) 1: syntax error
>> selftests: basic_percpu_ops_test
>> ========================================
>> ok 1.. selftests: basic_percpu_ops_test [PASS]
>> (standard_in) 1: syntax error
>> selftests: param_test
>> ========================================
>> ok 1.. selftests: param_test [PASS]
> 
> Hi Mathieu,
> 
> Odd. I don't see the error. I am curious if this specific to
> env. Can you reproduce this with one of the existing tests,
> kcmp or breakpoints

Yes, it reproduces:

cd tools/testing/selftests/kcmp
make run_tests
gcc -I../../../../usr/include/    kcmp_test.c  -o /home/efficios/git/linux-rseq/tools/testing/selftests/kcmp/kcmp_test
TAP version 13
(standard_in) 1: syntax error
selftests: kcmp_test
========================================
ok 1.. selftests: kcmp_test [PASS]

cd tools/testing/selftests/breakpoints
make run_tests
gcc     step_after_suspend_test.c  -o /home/efficios/git/linux-rseq/tools/testing/selftests/breakpoints/step_after_suspend_test
gcc     breakpoint_test.c  -o /home/efficios/git/linux-rseq/tools/testing/selftests/breakpoints/breakpoint_test
TAP version 13
(standard_in) 1: syntax error
selftests: step_after_suspend_test
========================================
not ok 1.. selftests:  step_after_suspend_test [FAIL]
(standard_in) 1: syntax error
selftests: breakpoint_test
========================================
ok 1.. selftests: breakpoint_test [PASS]

Thanks,

Mathieu


> 
>> 
>> With fix applied:
>> 
>> TAP version 13
>> selftests: basic_test
>> ========================================
>> ok 1..1 selftests: basic_test [PASS]
>> selftests: basic_percpu_ops_test
>> ========================================
>> ok 1..2 selftests: basic_percpu_ops_test [PASS]
>> selftests: param_test
>> ========================================
>> ok 1..3 selftests: param_test [PASS]
>> 
>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
>> Fixes: 1f87c7c15d7 ("selftests: lib.mk: change RUN_TESTS to print messages in
>> TAP13 format")
>> CC: Shuah Khan <shuahkh@osg.samsung.com>
>> CC: linux-kselftest@vger.kernel.org
>> ---
> 
> thanks,
> -- Shuah

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

  reply	other threads:[~2017-11-01 22:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-28 13:46 Mathieu Desnoyers
2017-11-01 21:33 ` Shuah Khan
2017-11-01 22:22   ` Mathieu Desnoyers [this message]
2017-11-01 22:24     ` Mathieu Desnoyers
2017-11-01 22:28       ` Shuah Khan
2018-04-27 20:17         ` Mathieu Desnoyers
2018-04-27 20:42           ` Shuah Khan
2018-04-27 21:05             ` Shuah Khan
2018-04-27 21:33               ` Mathieu Desnoyers
2018-04-27 21:41                 ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490563551.1701.1509574972486.JavaMail.zimbra@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=shuahkh@osg.samsung.com \
    --subject='Re: [PATCH 1/1] selftests: Fix lib.mk run_tests target shell script' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).