LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net> To: Al Viro <viro@ZenIV.linux.org.uk> Cc: Colin Walters <walters@redhat.com>, Ondrej Holy <oholy@redhat.com>, autofs mailing list <autofs@vger.kernel.org>, Kernel Mailing List <linux-kernel@vger.kernel.org>, David Howells <dhowells@redhat.com>, linux-fsdevel <linux-fsdevel@vger.kernel.org> Subject: [PATCH 1/3] autofs - make disc device user accessible Date: Wed, 10 May 2017 12:18:38 +0800 [thread overview] Message-ID: <149438991819.26550.11290804420751932707.stgit@pluto.themaw.net> (raw) The autofs miscellanous device ioctls that shouldn't require CAP_SYS_ADMIN need to be accessible to user space applications in order to be able to get information about autofs mounts. The module checks capabilities so the miscelaneous device should be fine with broad permissions. Signed-off-by: Ian Kent <raven@themaw.net> Cc: Colin Walters <walters@redhat.com> Cc: Ondrej Holy <oholy@redhat.com> Cc: stable@vger.kernel.org --- fs/autofs4/dev-ioctl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c index 734cbf8..9b58d6e 100644 --- a/fs/autofs4/dev-ioctl.c +++ b/fs/autofs4/dev-ioctl.c @@ -733,7 +733,8 @@ static const struct file_operations _dev_ioctl_fops = { static struct miscdevice _autofs_dev_ioctl_misc = { .minor = AUTOFS_MINOR, .name = AUTOFS_DEVICE_NAME, - .fops = &_dev_ioctl_fops + .fops = &_dev_ioctl_fops, + .mode = 0666 }; MODULE_ALIAS_MISCDEV(AUTOFS_MINOR);
next reply other threads:[~2017-05-10 4:18 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-10 4:18 Ian Kent [this message] 2017-05-10 4:18 ` [PATCH 2/3] autofs - make dev ioctl version and ismountpoint user accessible Ian Kent 2017-05-10 4:18 ` [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored Ian Kent 2017-05-12 12:49 ` Colin Walters 2017-11-21 1:53 ` NeilBrown 2017-11-22 4:28 ` Ian Kent 2017-11-23 0:36 ` Ian Kent 2017-11-23 2:21 ` NeilBrown 2017-11-23 2:46 ` Ian Kent 2017-11-23 3:04 ` Ian Kent 2017-11-23 4:49 ` NeilBrown 2017-11-23 6:34 ` Ian Kent 2017-11-27 16:01 ` Mike Marion 2017-11-27 23:43 ` Ian Kent 2017-11-28 0:29 ` Mike Marion 2017-11-29 1:17 ` NeilBrown 2017-11-29 2:13 ` Mike Marion 2017-11-29 2:28 ` Ian Kent 2017-11-29 2:48 ` NeilBrown 2017-11-29 3:14 ` Ian Kent 2017-11-29 2:56 ` Ian Kent 2017-11-29 3:45 ` NeilBrown 2017-11-29 6:00 ` Ian Kent 2017-11-29 7:39 ` NeilBrown 2017-11-30 0:00 ` Ian Kent 2017-11-29 16:51 ` Mike Marion 2017-11-23 0:47 ` NeilBrown 2017-11-23 1:43 ` Ian Kent 2017-11-23 2:26 ` Ian Kent 2017-11-23 3:04 ` NeilBrown 2017-11-23 3:41 ` Ian Kent
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=149438991819.26550.11290804420751932707.stgit@pluto.themaw.net \ --to=raven@themaw.net \ --cc=autofs@vger.kernel.org \ --cc=dhowells@redhat.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=oholy@redhat.com \ --cc=viro@ZenIV.linux.org.uk \ --cc=walters@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).