LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: dhowells@redhat.com, LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	Tony Luck <tony.luck@intel.com>, Michal Simek <monstr@monstr.eu>
Subject: Re: [patch 5/8] mn10300: Remove stale irq_chip.end
Date: Wed, 09 Feb 2011 15:28:25 +0000	[thread overview]
Message-ID: <15052.1297265305@redhat.com> (raw)
In-Reply-To: <20110203004210.434316157@linutronix.de>

Thomas Gleixner <tglx@linutronix.de> wrote:

> -static void mn10300_serial_nop(unsigned int irq)
> -{
> -}
> -
>  static struct irq_chip mn10300_serial_pic = {
>  	.name		= "mnserial",
>  	.ack		= mn10300_serial_mask_ack,
>  	.mask		= mn10300_serial_mask_ack,
>  	.mask_ack	= mn10300_serial_mask_ack,
>  	.unmask		= mn10300_serial_nop,
> -	.end		= mn10300_serial_nop,
>  };

This doesn't compile.  .unmask still refers to that function.

David

      parent reply	other threads:[~2011-02-09 15:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-03  0:46 [patch 0/8] genirq: Remove the last __do_IRQ() leftovers Thomas Gleixner
2011-02-03  0:46 ` [patch 1/8] frv: Remove stale irq_chip.end Thomas Gleixner
2011-02-03  0:46 ` [patch 2/8] ia64: " Thomas Gleixner
2011-02-03  0:46 ` [patch 3/8] microblaze: " Thomas Gleixner
2011-02-03 13:06   ` Michal Simek
2011-02-03  0:46 ` [patch 4/8] mips: " Thomas Gleixner
2011-02-03  0:46 ` [patch 5/8] mn10300: " Thomas Gleixner
2011-02-03  0:46 ` [patch 6/8] powerpc: " Thomas Gleixner
2011-02-03  0:47 ` [patch 7/8] um: " Thomas Gleixner
2011-02-03  0:47 ` [patch 8/8] genirq-remove-stale-irq-end.patch Thomas Gleixner
2011-02-09 15:28 ` David Howells [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15052.1297265305@redhat.com \
    --to=dhowells@redhat.com \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=monstr@monstr.eu \
    --cc=peterz@infradead.org \
    --cc=ralf@linux-mips.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --subject='Re: [patch 5/8] mn10300: Remove stale irq_chip.end' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).