LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: CK Hu <ck.hu@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: <ulrich.hecht+renesas@gmail.com>,
	<laurent.pinchart@ideasonboard.com>, <p.zabel@pengutronix.de>,
	<airlied@linux.ie>, <robh+dt@kernel.org>, <mark.rutland@arm.com>,
	<mturquette@baylibre.com>, <sboyd@codeaurora.org>,
	<lee.jones@linaro.org>, <davem@davemloft.net>,
	<gregkh@linuxfoundation.org>, <mchehab@kernel.org>,
	<rdunlap@infradead.org>, <pi-cheng.chen@linaro.org>,
	<sean.wang@mediatek.com>, <linux-clk@vger.kernel.org>,
	<linux@armlinux.org.uk>, <dri-devel@lists.freedesktop.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH 6/8] drm/mediatek: Add mfd support for mt8173
Date: Thu, 23 Nov 2017 16:51:27 +0800	[thread overview]
Message-ID: <1511427087.8489.4.camel@mtksdaap41> (raw)
In-Reply-To: <20171114214114.15793-7-mbrugger@suse.com>

Hi, Matthias:

On Tue, 2017-11-14 at 22:41 +0100, Matthias Brugger wrote:
> Use the MFD device for SoC mt8173. Probing via devicetree
> is no longer needed for any SoC, so delete it.
> 
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>

Acked-by: CK Hu <ck.hu@mediatek.com>

> ---
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 28 +++++++---------------------
>  1 file changed, 7 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 5a263aa3ab6e..1eb02acf229a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -409,20 +409,12 @@ static int mtk_drm_probe(struct platform_device *pdev)
>  	INIT_WORK(&private->commit.work, mtk_atomic_work);
>  	private->data = of_device_get_match_data(dev);
>  
> -	/* Check if called from mfd */
> -	if (!dev->of_node) {
> -		mmsys_private = dev_get_drvdata(pdev->dev.parent);
> -		private->data = (struct mtk_mmsys_driver_data *)
> -				platform_get_device_id(pdev)->driver_data;
> -		private->config_regs =
> -			syscon_node_to_regmap(mmsys_private->of_node);
> -		parent_node = mmsys_private->of_node->parent;
> -	} else {
> -		private->config_regs = syscon_node_to_regmap(dev->of_node);
> -		if (IS_ERR(private->config_regs))
> -			return PTR_ERR(private->config_regs);
> -		parent_node = dev->of_node->parent;
> -	}
> +	mmsys_private = dev_get_drvdata(pdev->dev.parent);
> +	private->data = (struct mtk_mmsys_driver_data *)
> +			platform_get_device_id(pdev)->driver_data;
> +	private->config_regs =
> +		syscon_node_to_regmap(mmsys_private->of_node);
> +	parent_node = mmsys_private->of_node->parent;
>  
>  	/* Iterate over sibling DISP function blocks */
>  	for_each_child_of_node(parent_node, node) {
> @@ -565,14 +557,9 @@ static int mtk_drm_sys_resume(struct device *dev)
>  static SIMPLE_DEV_PM_OPS(mtk_drm_pm_ops, mtk_drm_sys_suspend,
>  			 mtk_drm_sys_resume);
>  
> -static const struct of_device_id mtk_drm_of_ids[] = {
> -	{ .compatible = "mediatek,mt8173-mmsys",
> -	  .data = &mt8173_mmsys_driver_data},
> -	{ }
> -};
> -
>  static const struct platform_device_id mtk_drm_ids[] = {
>  	{ "drm-mt2701-mm", (kernel_ulong_t)&mt2701_mmsys_driver_data },
> +	{ "drm-mt8173-mm", (kernel_ulong_t)&mt8173_mmsys_driver_data },
>  	{ /* sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(platform, mtk_drm_ids);
> @@ -582,7 +569,6 @@ static struct platform_driver mtk_drm_platform_driver = {
>  	.remove	= mtk_drm_remove,
>  	.driver	= {
>  		.name	= "mediatek-drm",
> -		.of_match_table = mtk_drm_of_ids,
>  		.pm     = &mtk_drm_pm_ops,
>  	},
>  	.id_table = mtk_drm_ids,

  reply	other threads:[~2017-11-23  8:51 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14 21:41 [PATCH 0/8] arm/arm64: mediatek: Fix mmsys device probing Matthias Brugger
2017-11-14 21:41 ` [PATCH 1/8] drm/mediatek: Use regmap for register access Matthias Brugger
2017-11-23  5:44   ` CK Hu
2017-11-23  8:54   ` Philipp Zabel
2018-04-20  9:41     ` Matthias Brugger
2018-04-20 10:00       ` Philipp Zabel
2017-11-14 21:41 ` [PATCH 2/8] mfd: mtk-mmsys: Add mmsys driver Matthias Brugger
2017-11-23  9:04   ` CK Hu
2017-11-23 18:37     ` Matthias Brugger
2017-11-23  9:09   ` Philipp Zabel
2017-11-14 21:41 ` [PATCH 3/8] drm/mediatek: mt2701: switch to mfd probing Matthias Brugger
2017-11-23  5:48   ` CK Hu
2017-11-23  8:30     ` Matthias Brugger
2017-11-23  8:47       ` CK Hu
2017-11-23  9:12   ` Philipp Zabel
2017-11-14 21:41 ` [PATCH 4/8] clk: mediatek: mt2701-mm: switch to mfd device Matthias Brugger
2017-11-15  0:17   ` Stephen Boyd
2018-04-20 13:00     ` Matthias Brugger
2018-04-20 13:04       ` Matthias Brugger
2017-11-14 21:41 ` [PATCH 5/8] mfd: mtk-mmsys: Add mt8173 nodes Matthias Brugger
2017-11-23  9:13   ` Philipp Zabel
2017-11-14 21:41 ` [PATCH 6/8] drm/mediatek: Add mfd support for mt8173 Matthias Brugger
2017-11-23  8:51   ` CK Hu [this message]
2017-11-23  9:13   ` Philipp Zabel
2017-11-14 21:41 ` [PATCH 7/8] clk: mediatek: mt8173-mm: switch to mfd device Matthias Brugger
2017-11-15  0:16   ` Stephen Boyd
2017-11-14 21:41 ` [PATCH 8/8] MAINTAINERS: update Mediatek Soc entry Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1511427087.8489.4.camel@mtksdaap41 \
    --to=ck.hu@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=davem@davemloft.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mbrugger@suse.com \
    --cc=mchehab@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=pi-cheng.chen@linaro.org \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=sean.wang@mediatek.com \
    --cc=ulrich.hecht+renesas@gmail.com \
    --subject='Re: [PATCH 6/8] drm/mediatek: Add mfd support for mt8173' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).