LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Matthias Brugger <matthias.bgg@gmail.com>,
	ulrich.hecht+renesas@gmail.com,
	laurent.pinchart@ideasonboard.com, ck.hu@mediatek.com,
	airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com,
	mturquette@baylibre.com, sboyd@codeaurora.org,
	lee.jones@linaro.org
Cc: davem@davemloft.net, gregkh@linuxfoundation.org,
	mchehab@kernel.org, rdunlap@infradead.org,
	pi-cheng.chen@linaro.org, sean.wang@mediatek.com,
	linux-clk@vger.kernel.org, linux@armlinux.org.uk,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH 3/8] drm/mediatek: mt2701: switch to mfd probing.
Date: Thu, 23 Nov 2017 10:12:57 +0100	[thread overview]
Message-ID: <1511428377.7685.9.camel@pengutronix.de> (raw)
In-Reply-To: <20171114214114.15793-4-mbrugger@suse.com>

On Tue, 2017-11-14 at 22:41 +0100, Matthias Brugger wrote:
> With the mtk-mmsys MFD device in place, we switch the probing for
> mt2701 from device-tree to mfd.
> 
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 32 +++++++++++++++++++++++++-------
>  1 file changed, 25 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index dd249cf5121e..5a263aa3ab6e 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -21,6 +21,7 @@
>  #include <drm/drm_of.h>
>  #include <linux/component.h>
>  #include <linux/iommu.h>
> +#include <linux/mfd/mmsys.h>
>  #include <linux/mfd/syscon.h>
>  #include <linux/of_address.h>
>  #include <linux/of_platform.h>
> @@ -392,9 +393,10 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = {
>  
>  static int mtk_drm_probe(struct platform_device *pdev)
>  {
> +	struct mmsys_dev *mmsys_private;
>  	struct device *dev = &pdev->dev;
>  	struct mtk_drm_private *private;
> -	struct device_node *node;
> +	struct device_node *node, *parent_node;
>  	struct component_match *match = NULL;
>  	int ret;
>  	int i;
> @@ -407,12 +409,23 @@ static int mtk_drm_probe(struct platform_device *pdev)
>  	INIT_WORK(&private->commit.work, mtk_atomic_work);
>  	private->data = of_device_get_match_data(dev);
>  
> -	private->config_regs = syscon_node_to_regmap(dev->of_node);
> -	if (IS_ERR(private->config_regs))
> -		return PTR_ERR(private->config_regs);
> +	/* Check if called from mfd */
> +	if (!dev->of_node) {
> +		mmsys_private = dev_get_drvdata(pdev->dev.parent);
> +		private->data = (struct mtk_mmsys_driver_data *)
> +				platform_get_device_id(pdev)->driver_data;
> +		private->config_regs =
> +			syscon_node_to_regmap(mmsys_private->of_node);
> +		parent_node = mmsys_private->of_node->parent;

I think this could be just:

		mmsys_node = pdev->dev.parent->of_node;
		private->data = (struct mtk_mmsys_driver_data *)> +	
			platform_get_device_id(pdev)->driver_data;
		private->config_regs = syscon_node_to_regmap(mmsys_node);
		parent_node = mmsys_node->parent;

regards
Philipp

  parent reply	other threads:[~2017-11-23  9:13 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14 21:41 [PATCH 0/8] arm/arm64: mediatek: Fix mmsys device probing Matthias Brugger
2017-11-14 21:41 ` [PATCH 1/8] drm/mediatek: Use regmap for register access Matthias Brugger
2017-11-23  5:44   ` CK Hu
2017-11-23  8:54   ` Philipp Zabel
2018-04-20  9:41     ` Matthias Brugger
2018-04-20 10:00       ` Philipp Zabel
2017-11-14 21:41 ` [PATCH 2/8] mfd: mtk-mmsys: Add mmsys driver Matthias Brugger
2017-11-23  9:04   ` CK Hu
2017-11-23 18:37     ` Matthias Brugger
2017-11-23  9:09   ` Philipp Zabel
2017-11-14 21:41 ` [PATCH 3/8] drm/mediatek: mt2701: switch to mfd probing Matthias Brugger
2017-11-23  5:48   ` CK Hu
2017-11-23  8:30     ` Matthias Brugger
2017-11-23  8:47       ` CK Hu
2017-11-23  9:12   ` Philipp Zabel [this message]
2017-11-14 21:41 ` [PATCH 4/8] clk: mediatek: mt2701-mm: switch to mfd device Matthias Brugger
2017-11-15  0:17   ` Stephen Boyd
2018-04-20 13:00     ` Matthias Brugger
2018-04-20 13:04       ` Matthias Brugger
2017-11-14 21:41 ` [PATCH 5/8] mfd: mtk-mmsys: Add mt8173 nodes Matthias Brugger
2017-11-23  9:13   ` Philipp Zabel
2017-11-14 21:41 ` [PATCH 6/8] drm/mediatek: Add mfd support for mt8173 Matthias Brugger
2017-11-23  8:51   ` CK Hu
2017-11-23  9:13   ` Philipp Zabel
2017-11-14 21:41 ` [PATCH 7/8] clk: mediatek: mt8173-mm: switch to mfd device Matthias Brugger
2017-11-15  0:16   ` Stephen Boyd
2017-11-14 21:41 ` [PATCH 8/8] MAINTAINERS: update Mediatek Soc entry Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1511428377.7685.9.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=airlied@linux.ie \
    --cc=ck.hu@mediatek.com \
    --cc=davem@davemloft.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mbrugger@suse.com \
    --cc=mchehab@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=pi-cheng.chen@linaro.org \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=sean.wang@mediatek.com \
    --cc=ulrich.hecht+renesas@gmail.com \
    --subject='Re: [PATCH 3/8] drm/mediatek: mt2701: switch to mfd probing.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).