LKML Archive on
help / color / mirror / Atom feed
From: Joe Perches <>
To: OGAWA Hirofumi <>,
	Andrew Morton <>
Cc: David Howells <>,,
Subject: Re: [PATCH] fat: Fix sb_rdonly() change
Date: Thu, 23 Nov 2017 12:49:38 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, 2017-11-23 at 15:29 +0900, OGAWA Hirofumi wrote:
> Ouch forgot to add stable@
> -- 
> commit bc98a42c1f7d0f886c0c1b75a92a004976a46d9f introduced bug.

I think your commit message needs a bit more information.

It'd be useful to describe that the introduction of
sb_rdonly converted the bitwise & to a boolean and so
this conversion and comparison was made defective.

Are there any other instances of defective comparisons?

  reply	other threads:[~2017-11-23 20:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23  6:26 [PATCH] fat: Fix sb_rdonly() change OGAWA Hirofumi
2017-11-23  6:29 ` OGAWA Hirofumi
2017-11-23 20:49   ` Joe Perches [this message]
2017-11-24  6:07     ` OGAWA Hirofumi
2017-11-24  6:51       ` Joe Perches
2017-11-28 22:41         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).