From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbdKXGvj (ORCPT ); Fri, 24 Nov 2017 01:51:39 -0500 Received: from smtprelay0052.hostedemail.com ([216.40.44.52]:44410 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751136AbdKXGvi (ORCPT ); Fri, 24 Nov 2017 01:51:38 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:2892:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:3874:4321:5007:7903:9010:10004:10400:10848:11232:11658:11914:12043:12296:12438:12533:12555:12679:12740:12760:12895:13069:13095:13161:13229:13311:13357:13439:14181:14659:14721:14775:21080:21433:21627:30054:30070:30075:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: match68_2b1429248575c X-Filterd-Recvd-Size: 1897 Message-ID: <1511506294.8230.6.camel@perches.com> Subject: Re: [PATCH] fat: Fix sb_rdonly() change From: Joe Perches To: OGAWA Hirofumi Cc: Andrew Morton , David Howells , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Date: Thu, 23 Nov 2017 22:51:34 -0800 In-Reply-To: <873754i512.fsf@mail.parknet.co.jp> References: <87mv3d5x51.fsf@mail.parknet.co.jp> <87ine15wzx.fsf@mail.parknet.co.jp> <1511470178.5308.2.camel@perches.com> <873754i512.fsf@mail.parknet.co.jp> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-11-24 at 15:07 +0900, OGAWA Hirofumi wrote: > Joe Perches writes: > > > On Thu, 2017-11-23 at 15:29 +0900, OGAWA Hirofumi wrote: > > > Ouch forgot to add stable@ > > > > > > -- > > > commit bc98a42c1f7d0f886c0c1b75a92a004976a46d9f introduced bug. > > > > I think your commit message needs a bit more information. > > > > It'd be useful to describe that the introduction of > > sb_rdonly converted the bitwise & to a boolean and so > > this conversion and comparison was made defective. > > > > Are there any other instances of defective comparisons? > > Please ask to that patch author. The patch author, David Howells, is on the cc list. btw: It seems all the the other uses use a (bool) cast of the (*flags & MS_RDONLY) and a comparison of sb_rdonly(sb). It would make sense to change the argument type of the ext[24]_setup_super int read_only arg to bool to match the sb_rdonly() type.