LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Byungchul Park <byungchul.park@lge.com>
To: peterz@infradead.org, mingo@kernel.org, rostedt@goodmis.org
Cc: tglx@linutronix.de, raistlin@linux.it,
linux-kernel@vger.kernel.org, juri.lelli@gmail.com,
bristot@redhat.com, kernel-team@lge.com
Subject: [RESEND PATCH v3 1/2] sched/deadline: Add cpudl_maximum_dl() for clean-up
Date: Mon, 8 Jan 2018 15:14:40 +0900 [thread overview]
Message-ID: <1515392081-32320-1-git-send-email-byungchul.park@lge.com> (raw)
Changes from v2
- Run spellchecker over the text and fix typos
- Add acked-by Daniel
Changes from v1
- Enhance commit msg
- Prevent WARN in cpumask_test_cpu() in cpudl_find() when best_cpu == -1
-----8<-----
>From 7735382d07ae6a61d740ae39ba2ecf169d43b8a2 Mon Sep 17 00:00:00 2001
From: Byungchul Park <byungchul.park@lge.com>
Date: Wed, 22 Mar 2017 14:25:56 +0900
Subject: [RESEND PATCH v3 1/2] sched/deadline: Add cpudl_maximum_dl() for clean-up
Current code uses cpudl_maximum() to get the root node's cpu, while it
directly accesses the root node like 'cp->elements[0].dl' to get the
root node's dl. It would be more readable to add a function for the dl,
as well. Added it.
Signed-off-by: Byungchul Park <byungchul.park@lge.com>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Daniel Bristot de Oliveira <bristot@redhat.com>
---
kernel/sched/cpudeadline.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c
index 8d9562d..9f02035 100644
--- a/kernel/sched/cpudeadline.c
+++ b/kernel/sched/cpudeadline.c
@@ -108,11 +108,16 @@ static void cpudl_heapify(struct cpudl *cp, int idx)
cpudl_heapify_down(cp, idx);
}
-static inline int cpudl_maximum(struct cpudl *cp)
+static inline int cpudl_maximum_cpu(struct cpudl *cp)
{
return cp->elements[0].cpu;
}
+static inline u64 cpudl_maximum_dl(struct cpudl *cp)
+{
+ return cp->elements[0].dl;
+}
+
/*
* cpudl_find - find the best (later-dl) CPU in the system
* @cp: the cpudl max-heap context
@@ -130,11 +135,11 @@ int cpudl_find(struct cpudl *cp, struct task_struct *p,
cpumask_and(later_mask, cp->free_cpus, &p->cpus_allowed)) {
return 1;
} else {
- int best_cpu = cpudl_maximum(cp);
+ int best_cpu = cpudl_maximum_cpu(cp);
WARN_ON(best_cpu != -1 && !cpu_present(best_cpu));
if (cpumask_test_cpu(best_cpu, &p->cpus_allowed) &&
- dl_time_before(dl_se->deadline, cp->elements[0].dl)) {
+ dl_time_before(dl_se->deadline, cpudl_maximum_dl(cp))) {
if (later_mask)
cpumask_set_cpu(best_cpu, later_mask);
--
1.9.1
next reply other threads:[~2018-01-08 6:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 6:14 Byungchul Park [this message]
2018-01-08 6:14 ` [RESEND PATCH v3 2/2] sched/deadline: Initialize cp->elements[].cpu to an invalid value Byungchul Park
2018-06-01 6:12 ` [RESEND, v3, " Joel Fernandes
2018-06-01 6:18 ` Joel Fernandes
2018-06-01 7:10 ` Byungchul Park
2018-06-01 15:52 ` Joel Fernandes
2018-06-03 5:20 ` Byungchul Park
2018-01-11 9:07 ` [RESEND PATCH v3 1/2] sched/deadline: Add cpudl_maximum_dl() for clean-up Peter Zijlstra
2018-02-09 0:37 ` Byungchul Park
2018-02-26 7:51 ` Byungchul Park
2018-03-13 5:52 ` Byungchul Park
2018-04-23 7:01 ` Byungchul Park
2018-05-09 6:33 ` Byungchul Park
2018-05-25 5:13 ` Byungchul Park
2018-06-01 3:07 ` Byungchul Park
2018-06-01 6:02 ` Joel Fernandes
2018-06-01 6:30 ` Byungchul Park
-- strict thread matches above, loose matches on Subject: below --
2017-12-28 23:32 Byungchul Park
2017-12-19 1:19 Byungchul Park
2017-12-22 6:53 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515392081-32320-1-git-send-email-byungchul.park@lge.com \
--to=byungchul.park@lge.com \
--cc=bristot@redhat.com \
--cc=juri.lelli@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=raistlin@linux.it \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--subject='Re: [RESEND PATCH v3 1/2] sched/deadline: Add cpudl_maximum_dl() for clean-up' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).