LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Eddie James <eajames@linux.vnet.ibm.com>, linux-kernel@vger.kernel.org
Cc: linux-clk@vger.kernel.org, joel@jms.id.au,
mturquette@baylibre.com, eajames@linux.vnet.ibm.com,
mine260309@gmail.com, ryan_chen@aspeedtech.com
Subject: Re: [PATCH v2 2/2] clk: aspeed: Prevent reset if clock is enabled
Date: Thu, 15 Mar 2018 11:14:38 -0700 [thread overview]
Message-ID: <152113767831.111154.2144307841968232404@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1520542640-9185-3-git-send-email-eajames@linux.vnet.ibm.com>
Quoting Eddie James (2018-03-08 12:57:20)
> According to the Aspeed specification, the reset and enable sequence
> should be done when the clock is stopped. The specification doesn't
> define behavior if the reset is done while the clock is enabled.
>
> From testing on the AST2500, the LPC Controller has problems if the
> clock is reset while enabled.
>
> Therefore, check whether the clock is enabled or not before performing
> the reset and enable sequence in the Aspeed clock driver.
>
> Root-caused-by: Lei Yu <mine260309@gmail.com>
> Signed-off-by: Eddie James <eajames@linux.vnet.ibm.com>
> ---
Applied to clk-fixes
next prev parent reply other threads:[~2018-03-15 18:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 20:57 [PATCH v2 0/2] clk: aspeed: Fix is_enabled and prevent reset if clock enabled Eddie James
2018-03-08 20:57 ` [PATCH v2 1/2] clk: aspeed: Fix is_enabled for certain clocks Eddie James
2018-03-13 5:40 ` Joel Stanley
2018-03-15 18:14 ` Stephen Boyd
2018-03-08 20:57 ` [PATCH v2 2/2] clk: aspeed: Prevent reset if clock is enabled Eddie James
2018-03-09 3:23 ` Lei YU
[not found] ` <CAARXrtktSUMBuHUUjqTgrWNZaHVkOC9DUQEr4WKeGNz2z6WVdA@mail.gmail.com>
2018-03-09 5:02 ` Joel Stanley
2018-03-13 5:42 ` Joel Stanley
2018-03-15 18:14 ` Stephen Boyd [this message]
2018-03-10 0:41 ` [PATCH v2 0/2] clk: aspeed: Fix is_enabled and prevent reset if clock enabled Stephen Boyd
2018-03-14 19:11 ` Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152113767831.111154.2144307841968232404@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=eajames@linux.vnet.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mine260309@gmail.com \
--cc=mturquette@baylibre.com \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).