LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Yang Shi <yang.shi@linux.alibaba.com>
To: akpm@linux-foundation.org
Cc: yang.shi@linux.alibaba.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH 5/8] ipc: shm: pass atomic parameter to do_munmap()
Date: Wed, 21 Mar 2018 05:31:23 +0800 [thread overview]
Message-ID: <1521581486-99134-6-git-send-email-yang.shi@linux.alibaba.com> (raw)
In-Reply-To: <1521581486-99134-1-git-send-email-yang.shi@linux.alibaba.com>
It looks safe to do unlock/relock mmap_sem in the middle of shmat(), so
passing "false" here.
Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
---
ipc/shm.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/ipc/shm.c b/ipc/shm.c
index 4643865..1617523 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -1537,7 +1537,8 @@ long do_shmat(int shmid, char __user *shmaddr, int shmflg,
*/
file = vma->vm_file;
size = i_size_read(file_inode(vma->vm_file));
- do_munmap(mm, vma->vm_start, vma->vm_end - vma->vm_start, NULL);
+ do_munmap(mm, vma->vm_start, vma->vm_end - vma->vm_start,
+ NULL, false);
/*
* We discovered the size of the shm segment, so
* break out of here and fall through to the next
@@ -1564,7 +1565,8 @@ long do_shmat(int shmid, char __user *shmaddr, int shmflg,
if ((vma->vm_ops == &shm_vm_ops) &&
((vma->vm_start - addr)/PAGE_SIZE == vma->vm_pgoff) &&
(vma->vm_file == file))
- do_munmap(mm, vma->vm_start, vma->vm_end - vma->vm_start, NULL);
+ do_munmap(mm, vma->vm_start, vma->vm_end - vma->vm_start,
+ NULL, false);
vma = next;
}
@@ -1573,7 +1575,8 @@ long do_shmat(int shmid, char __user *shmaddr, int shmflg,
* given
*/
if (vma && vma->vm_start == addr && vma->vm_ops == &shm_vm_ops) {
- do_munmap(mm, vma->vm_start, vma->vm_end - vma->vm_start, NULL);
+ do_munmap(mm, vma->vm_start, vma->vm_end - vma->vm_start,
+ NULL, false);
retval = 0;
}
--
1.8.3.1
next prev parent reply other threads:[~2018-03-20 21:32 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 21:31 [RFC PATCH 0/8] Drop mmap_sem during unmapping large map Yang Shi
2018-03-20 21:31 ` [RFC PATCH 1/8] mm: mmap: unmap large mapping by section Yang Shi
2018-03-21 13:08 ` Michal Hocko
2018-03-21 16:31 ` Yang Shi
2018-03-21 17:29 ` Matthew Wilcox
2018-03-21 21:45 ` Yang Shi
2018-03-21 22:15 ` Matthew Wilcox
2018-03-21 22:40 ` Yang Shi
2018-03-21 22:46 ` Matthew Wilcox
2018-03-22 15:32 ` Laurent Dufour
2018-03-22 15:40 ` Matthew Wilcox
2018-03-22 15:54 ` Laurent Dufour
2018-03-22 16:05 ` Matthew Wilcox
2018-03-22 16:18 ` Laurent Dufour
2018-03-22 16:46 ` Yang Shi
2018-03-23 13:03 ` Laurent Dufour
2018-03-22 16:51 ` Matthew Wilcox
2018-03-22 16:49 ` Yang Shi
2018-03-22 17:34 ` Yang Shi
2018-03-22 18:48 ` Matthew Wilcox
2018-03-24 18:24 ` Jerome Glisse
2018-03-21 13:14 ` Michal Hocko
2018-03-21 16:50 ` Yang Shi
2018-03-21 17:16 ` Yang Shi
2018-03-21 21:23 ` Michal Hocko
2018-03-21 22:36 ` Yang Shi
2018-03-22 9:10 ` Michal Hocko
2018-03-22 16:06 ` Yang Shi
2018-03-22 16:12 ` Michal Hocko
2018-03-22 16:13 ` Matthew Wilcox
2018-03-22 16:28 ` Laurent Dufour
2018-03-22 16:36 ` David Laight
2018-03-20 21:31 ` [RFC PATCH 2/8] mm: mmap: pass atomic parameter to do_munmap() call sites Yang Shi
2018-03-20 21:31 ` [RFC PATCH 3/8] mm: mremap: pass atomic parameter to do_munmap() Yang Shi
2018-03-20 21:31 ` [RFC PATCH 4/8] mm: nommu: add " Yang Shi
2018-03-20 21:31 ` Yang Shi [this message]
2018-03-20 21:31 ` [RFC PATCH 6/8] fs: proc/vmcore: pass " Yang Shi
2018-03-20 21:31 ` [RFC PATCH 7/8] x86: mpx: " Yang Shi
2018-03-20 22:35 ` Thomas Gleixner
2018-03-21 16:53 ` Yang Shi
2018-03-20 21:31 ` [RFC PATCH 8/8] x86: vma: " Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521581486-99134-6-git-send-email-yang.shi@linux.alibaba.com \
--to=yang.shi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--subject='Re: [RFC PATCH 5/8] ipc: shm: pass atomic parameter to do_munmap()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).