LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Eugen Hristev <eugen.hristev@microchip.com>
To: <jic23@kernel.org>, <ludovic.desroches@microchip.com>,
	<alexandre.belloni@bootlin.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-iio@vger.kernel.org>, <linux-input@vger.kernel.org>,
	<nicolas.ferre@microchip.com>, <dmitry.torokhov@gmail.com>
Cc: Eugen Hristev <eugen.hristev@microchip.com>
Subject: [PATCH v2 04/10] iio: inkern: add module put/get on iio dev module when requesting channels
Date: Tue, 27 Mar 2018 15:32:37 +0300	[thread overview]
Message-ID: <1522153963-1121-5-git-send-email-eugen.hristev@microchip.com> (raw)
In-Reply-To: <1522153963-1121-1-git-send-email-eugen.hristev@microchip.com>

When requesting channels for a particular consumer device,
besides requesting the device (incrementing the reference counter), also
do it for the driver module of the iio dev. This will avoid the situation
where the producer IIO device can be removed and the consumer is still
present in the kernel.

Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
 drivers/iio/inkern.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
index ec98790..68d9b87 100644
--- a/drivers/iio/inkern.c
+++ b/drivers/iio/inkern.c
@@ -11,6 +11,7 @@
 #include <linux/slab.h>
 #include <linux/mutex.h>
 #include <linux/of.h>
+#include <linux/module.h>
 
 #include <linux/iio/iio.h>
 #include "iio_core.h"
@@ -152,6 +153,7 @@ static int __of_iio_channel_get(struct iio_channel *channel,
 	if (index < 0)
 		goto err_put;
 	channel->channel = &indio_dev->channels[index];
+	try_module_get(channel->indio_dev->driver_module);
 
 	return 0;
 
@@ -256,8 +258,10 @@ static struct iio_channel *of_iio_channel_get_all(struct device *dev)
 	return chans;
 
 error_free_chans:
-	for (i = 0; i < mapind; i++)
+	for (i = 0; i < mapind; i++) {
+		module_put(chans[i].indio_dev->driver_module);
 		iio_device_put(chans[i].indio_dev);
+	}
 	kfree(chans);
 	return ERR_PTR(ret);
 }
@@ -351,6 +355,7 @@ void iio_channel_release(struct iio_channel *channel)
 {
 	if (!channel)
 		return;
+	module_put(channel->indio_dev->driver_module);
 	iio_device_put(channel->indio_dev);
 	kfree(channel);
 }
@@ -482,6 +487,7 @@ void iio_channel_release_all(struct iio_channel *channels)
 	struct iio_channel *chan = &channels[0];
 
 	while (chan->indio_dev) {
+		module_put(chan->indio_dev->driver_module);
 		iio_device_put(chan->indio_dev);
 		chan++;
 	}
-- 
2.7.4

  parent reply	other threads:[~2018-03-27 12:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27 12:32 [PATCH v2 00/10] Add support for SAMA5D2 touchscreen Eugen Hristev
2018-03-27 12:32 ` [PATCH v2 01/10] MAINTAINERS: add generic resistive touchscreen adc Eugen Hristev
2018-03-27 12:32 ` [PATCH v2 02/10] iio: Add channel for Position Relative Eugen Hristev
2018-03-27 12:32 ` [PATCH v2 03/10] dt-bindings: input: touchscreen: touch_adc: create bindings Eugen Hristev
2018-04-09 18:46   ` Rob Herring
2018-03-27 12:32 ` Eugen Hristev [this message]
2018-03-27 12:32 ` [PATCH v2 05/10] iio: adc: at91-sama5d2_adc: fix channel configuration for differential channels Eugen Hristev
2018-03-30 12:17   ` Jonathan Cameron
2018-03-27 12:32 ` [PATCH v2 06/10] iio: adc: at91-sama5d2_adc: add support for position and pressure channels Eugen Hristev
2018-03-30 12:47   ` Jonathan Cameron
2018-03-27 12:32 ` [PATCH v2 07/10] input: touchscreen: touch_adc: add generic resistive ADC touchscreen Eugen Hristev
2018-03-30 12:58   ` Jonathan Cameron
2018-03-30 18:09     ` Dmitry Torokhov
2018-04-06 15:13       ` Jonathan Cameron
2018-03-27 12:32 ` [PATCH v2 08/10] dt-bindings: iio: adc: at91-sama5d2_adc: add channel specific consumer info Eugen Hristev
2018-04-09 18:47   ` Rob Herring
2018-03-27 12:32 ` [PATCH v2 09/10] ARM: dts: at91: sama5d2: add channel cells for ADC device Eugen Hristev
2018-03-27 12:32 ` [PATCH v2 10/10] ARM: dts: at91: sama5d2: Add resistive touch device Eugen Hristev
2018-03-30 13:02 ` [PATCH v2 00/10] Add support for SAMA5D2 touchscreen Jonathan Cameron
2018-04-10  7:38   ` Quentin Schulz
2018-04-10 13:47     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1522153963-1121-5-git-send-email-eugen.hristev@microchip.com \
    --to=eugen.hristev@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jic23@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=nicolas.ferre@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).