LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Eric Auger <eric.auger@redhat.com> To: eric.auger.pro@gmail.com, eric.auger@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, cdall@kernel.org, peter.maydell@linaro.org Cc: andre.przywara@arm.com, drjones@redhat.com, wei@redhat.com Subject: [PATCH v3 01/12] KVM: arm/arm64: Set dist->spis to NULL after kfree Date: Fri, 13 Apr 2018 10:20:47 +0200 [thread overview] Message-ID: <1523607658-9166-2-git-send-email-eric.auger@redhat.com> (raw) In-Reply-To: <1523607658-9166-1-git-send-email-eric.auger@redhat.com> in case kvm_vgic_map_resources() fails, typically if the vgic distributor is not defined, __kvm_vgic_destroy will be called several times. Indeed kvm_vgic_map_resources() is called on first vcpu run. As a result dist->spis is freeed more than once and on the second time it causes a "kernel BUG at mm/slub.c:3912!" Set dist->spis to NULL to avoid the crash. Fixes: ad275b8bb1e6 ("KVM: arm/arm64: vgic-new: vgic_init: implement vgic_init") Signed-off-by: Eric Auger <eric.auger@redhat.com> Reviewed-by: Marc Zyngier <marc.zyngier@arm.com> --- v2 -> v3: - added Marc's R-b and Fixed commit --- virt/kvm/arm/vgic/vgic-init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/virt/kvm/arm/vgic/vgic-init.c b/virt/kvm/arm/vgic/vgic-init.c index 68378fe..c52f03d 100644 --- a/virt/kvm/arm/vgic/vgic-init.c +++ b/virt/kvm/arm/vgic/vgic-init.c @@ -308,6 +308,7 @@ static void kvm_vgic_dist_destroy(struct kvm *kvm) dist->initialized = false; kfree(dist->spis); + dist->spis = NULL; dist->nr_spis = 0; if (vgic_supports_direct_msis(kvm)) -- 2.5.5
next prev parent reply other threads:[~2018-04-13 8:26 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-13 8:20 [PATCH v3 00/12] KVM: arm/arm64: Allow multiple GICv3 redistributor regions Eric Auger 2018-04-13 8:20 ` Eric Auger [this message] 2018-04-24 21:06 ` [PATCH v3 01/12] KVM: arm/arm64: Set dist->spis to NULL after kfree Christoffer Dall 2018-04-13 8:20 ` [PATCH v3 02/12] KVM: arm/arm64: Document KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION Eric Auger 2018-04-13 9:00 ` Peter Maydell 2018-04-24 16:46 ` Christoffer Dall 2018-04-24 16:50 ` Peter Maydell 2018-04-24 20:34 ` Auger Eric 2018-04-24 21:12 ` Christoffer Dall 2018-04-13 8:20 ` [PATCH v3 03/12] KVM: arm/arm64: Replace the single rdist region by a list Eric Auger 2018-04-24 21:06 ` Christoffer Dall 2018-04-13 8:20 ` [PATCH v3 04/12] KVM: arm/arm64: Helper to locate free rdist index Eric Auger 2018-04-24 21:07 ` Christoffer Dall 2018-04-26 7:47 ` Auger Eric 2018-04-13 8:20 ` [PATCH v3 05/12] KVM: arm/arm64: Revisit Redistributor TYPER last bit computation Eric Auger 2018-04-24 21:06 ` Christoffer Dall 2018-04-13 8:20 ` [PATCH v3 06/12] KVM: arm/arm64: Helper to register a new redistributor region Eric Auger 2018-04-24 16:47 ` Christoffer Dall 2018-04-26 7:32 ` Auger Eric 2018-04-26 10:04 ` Christoffer Dall 2018-04-13 8:20 ` [PATCH v3 07/12] KVM: arm/arm64: Adapt vgic_v3_check_base to multiple rdist regions Eric Auger 2018-04-24 21:07 ` Christoffer Dall 2018-04-26 8:29 ` Auger Eric 2018-04-26 10:06 ` Christoffer Dall 2018-04-26 14:52 ` Auger Eric 2018-04-13 8:20 ` [PATCH v3 08/12] KVM: arm/arm64: Check vcpu redist base before registering an iodev Eric Auger 2018-04-24 21:07 ` Christoffer Dall 2018-04-26 9:25 ` Auger Eric 2018-04-26 10:12 ` Christoffer Dall 2018-04-13 8:20 ` [PATCH v3 09/12] KVM: arm/arm64: Check all vcpu redistributors are set on map_resources Eric Auger 2018-04-24 21:08 ` Christoffer Dall 2018-04-26 9:56 ` Auger Eric 2018-04-26 10:16 ` Christoffer Dall 2018-04-13 8:20 ` [PATCH v3 10/12] KVM: arm/arm64: Add KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION Eric Auger 2018-04-24 21:08 ` Christoffer Dall 2018-04-13 8:20 ` [PATCH v3 11/12] KVM: arm/arm64: Implement KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION Eric Auger 2018-04-24 21:06 ` Christoffer Dall 2018-04-30 7:25 ` Auger Eric 2018-04-27 19:14 ` Christoffer Dall 2018-04-13 8:20 ` [PATCH v3 12/12] KVM: arm/arm64: Bump VGIC_V3_MAX_CPUS to 512 Eric Auger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1523607658-9166-2-git-send-email-eric.auger@redhat.com \ --to=eric.auger@redhat.com \ --cc=andre.przywara@arm.com \ --cc=cdall@kernel.org \ --cc=drjones@redhat.com \ --cc=eric.auger.pro@gmail.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=peter.maydell@linaro.org \ --cc=wei@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).