LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chintan Pandya <cpandya@codeaurora.org>
To: vbabka@suse.cz, labbott@redhat.com, catalin.marinas@arm.com,
	hannes@cmpxchg.org, f.fainelli@gmail.com, xieyisheng1@huawei.com,
	ard.biesheuvel@linaro.org, richard.weiyang@gmail.com,
	byungchul.park@lge.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	khandual@linux.vnet.ibm.com, mhocko@kernel.org,
	Chintan Pandya <cpandya@codeaurora.org>
Subject: [PATCH v2 0/2] vunmap and debug objects
Date: Tue, 17 Apr 2018 16:13:46 +0530	[thread overview]
Message-ID: <1523961828-9485-1-git-send-email-cpandya@codeaurora.org> (raw)

I'm not entirely sure, how debug objects are really
useful in vmalloc framework.

I'm assuming they are useful in some ways. So, there
are 2 issues in that. First patch is avoiding possible
race scenario and second patch passes _proper_ args
in debug object APIs. Both these patches can help
debug objects to be in consistent state.

We've observed some list corruptions in debug objects.
However, no claims that these patches will be fixing
them.

If one has an opinion that debug object has no use in
vmalloc framework, I would raise a patch to remove
them from the vunmap leg.

Below 2 patches are rebased over tip + my other patch in
review "[PATCH v2] mm: vmalloc: Clean up vunmap to avoid
pgtable ops twice"

Chintan Pandya (2):
  mm: vmalloc: Avoid racy handling of debugobjects in vunmap
  mm: vmalloc: Pass proper vm_start into debugobjects

>From V1->V2:
 - Incorporated Anshuman's comment about missing corrections
   in vm_unmap_ram()

 mm/vmalloc.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation
Center, Inc., is a member of Code Aurora Forum, a Linux Foundation
Collaborative Project

             reply	other threads:[~2018-04-17 10:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17 10:43 Chintan Pandya [this message]
2018-04-17 10:43 ` [PATCH v2 1/2] mm: vmalloc: Avoid racy handling of debugobjects in vunmap Chintan Pandya
2018-04-17 10:43 ` [PATCH v2 2/2] mm: vmalloc: Pass proper vm_start into debugobjects Chintan Pandya
2018-04-30 23:04   ` Andrew Morton
2018-05-01  5:24     ` Chintan Pandya
2018-05-03 21:42   ` Andrew Morton
2018-05-04  5:55     ` Chintan Pandya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1523961828-9485-1-git-send-email-cpandya@codeaurora.org \
    --to=cpandya@codeaurora.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=byungchul.park@lge.com \
    --cc=catalin.marinas@arm.com \
    --cc=f.fainelli@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=richard.weiyang@gmail.com \
    --cc=vbabka@suse.cz \
    --cc=xieyisheng1@huawei.com \
    --subject='Re: [PATCH v2 0/2] vunmap and debug objects' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).