LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Fabrice Gasnier <fabrice.gasnier@st.com> To: <lee.jones@linaro.org>, <alexandre.torgue@st.com> Cc: <dan.carpenter@oracle.com>, <thierry.reding@gmail.com>, <benjamin.gaignard@linaro.org>, <robh+dt@kernel.org>, <mark.rutland@arm.com>, <linux@armlinux.org.uk>, <mcoquelin.stm32@gmail.com>, <fabrice.gasnier@st.com>, <benjamin.gaignard@st.com>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-pwm@vger.kernel.org> Subject: [PATCH v5 4/6] pwm: stm32: improve capture by tuning counter prescaler Date: Tue, 17 Apr 2018 15:38:31 +0200 [thread overview] Message-ID: <1523972313-28765-5-git-send-email-fabrice.gasnier@st.com> (raw) In-Reply-To: <1523972313-28765-1-git-send-email-fabrice.gasnier@st.com> Currently, capture is based on timeout window to configure prescaler. PWM capture framework provides 1s window at the time of writing. There's place for improvement, after input signal has been captured once: - Finer tune counter clock prescaler, by using 1st capture result (with arbitrary margin). - Do a 2nd capture, with scaled capture window. This increases accuracy, especially at high rates. Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> Acked-by: Thierry Reding <thierry.reding@gmail.com> --- Changes in v2: - Adopt DMA read from MFD core. --- drivers/pwm/pwm-stm32.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c index ed3961b..9a50acd 100644 --- a/drivers/pwm/pwm-stm32.c +++ b/drivers/pwm/pwm-stm32.c @@ -168,7 +168,7 @@ static int stm32_pwm_capture(struct pwm_chip *chip, struct pwm_device *pwm, struct stm32_pwm *priv = to_stm32_pwm_dev(chip); unsigned long long prd, div, dty; unsigned long rate; - unsigned int psc = 0; + unsigned int psc = 0, scale; u32 raw_prd, raw_dty; int ret = 0; @@ -219,6 +219,28 @@ static int stm32_pwm_capture(struct pwm_chip *chip, struct pwm_device *pwm, if (ret) goto stop; + /* + * Got a capture. Try to improve accuracy at high rates: + * - decrease counter clock prescaler, scale up to max rate. + */ + if (raw_prd) { + u32 max_arr = priv->max_arr - 0x1000; /* arbitrary margin */ + + scale = max_arr / min(max_arr, raw_prd); + } else { + scale = priv->max_arr; /* bellow resolution, use max scale */ + } + + if (psc && scale > 1) { + /* 2nd measure with new scale */ + psc /= scale; + regmap_write(priv->regmap, TIM_PSC, psc); + ret = stm32_pwm_raw_capture(priv, pwm, tmo_ms, &raw_prd, + &raw_dty); + if (ret) + goto stop; + } + prd = (unsigned long long)raw_prd * (psc + 1) * NSEC_PER_SEC; result->period = DIV_ROUND_UP_ULL(prd, rate); dty = (unsigned long long)raw_dty * (psc + 1) * NSEC_PER_SEC; -- 1.9.1
next prev parent reply other threads:[~2018-04-17 13:41 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-17 13:38 [PATCH v5 0/6] Add support for PWM input capture on STM32 Fabrice Gasnier 2018-04-17 13:38 ` [PATCH v5 1/6] dt-bindings: mfd: stm32-timers: add support for dmas Fabrice Gasnier 2018-04-17 13:38 ` [PATCH v5 2/6] " Fabrice Gasnier 2018-05-02 9:20 ` Fabrice Gasnier 2018-04-17 13:38 ` [PATCH v5 3/6] pwm: stm32: add capture support Fabrice Gasnier 2018-04-17 13:38 ` Fabrice Gasnier [this message] 2018-04-17 13:38 ` [PATCH v5 5/6] pwm: stm32: use input prescaler to improve period capture Fabrice Gasnier 2018-04-17 13:38 ` [PATCH v5 6/6] ARM: dts: stm32: Enable pwm3 input capture on stm32f429i-eval Fabrice Gasnier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1523972313-28765-5-git-send-email-fabrice.gasnier@st.com \ --to=fabrice.gasnier@st.com \ --cc=alexandre.torgue@st.com \ --cc=benjamin.gaignard@linaro.org \ --cc=benjamin.gaignard@st.com \ --cc=dan.carpenter@oracle.com \ --cc=devicetree@vger.kernel.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mark.rutland@arm.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=robh+dt@kernel.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).