LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Anson Huang <Anson.Huang@nxp.com>
To: daniel.lezcano@linaro.org, tglx@linutronix.de,
	linux-kernel@vger.kernel.org
Cc: Linux-imx@nxp.com
Subject: [PATCH] clocksource: imx-tpm: correct -ETIME return condition check
Date: Thu, 19 Apr 2018 14:04:43 +0800	[thread overview]
Message-ID: <1524117883-2484-1-git-send-email-Anson.Huang@nxp.com> (raw)

The additional brakets added to tpm_set_next_event's return
value computation causes (int) forced type conversion NOT
taking effect, and the incorrect value return will cause
various system timer issue, like RCU stall etc..

This patch removes the additional brakets to make sure
tpm_set_next_event always returns correct value.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
	resend, since I got failure message of sending mail to linux-kernel@vger.kernel.org.
 drivers/clocksource/timer-imx-tpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-imx-tpm.c b/drivers/clocksource/timer-imx-tpm.c
index 05d97a6..6c83184 100644
--- a/drivers/clocksource/timer-imx-tpm.c
+++ b/drivers/clocksource/timer-imx-tpm.c
@@ -114,7 +114,7 @@ static int tpm_set_next_event(unsigned long delta,
 	 * of writing CNT registers which may cause the min_delta event got
 	 * missed, so we need add a ETIME check here in case it happened.
 	 */
-	return (int)((next - now) <= 0) ? -ETIME : 0;
+	return (int)(next - now) <= 0 ? -ETIME : 0;
 }
 
 static int tpm_set_state_oneshot(struct clock_event_device *evt)
-- 
2.7.4

             reply	other threads:[~2018-04-19  6:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19  6:04 Anson Huang [this message]
2018-04-19  7:14 ` A.s. Dong
2018-04-19 11:25 ` [tip:timers/urgent] clocksource/imx-tpm: Correct " tip-bot for Anson Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524117883-2484-1-git-send-email-Anson.Huang@nxp.com \
    --to=anson.huang@nxp.com \
    --cc=Linux-imx@nxp.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH] clocksource: imx-tpm: correct -ETIME return condition check' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).