LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] HISI LPC: Add Kconfig MFD_CORE dependency
@ 2018-04-19 14:14 John Garry
  2018-04-26 14:53 ` Arnd Bergmann
  0 siblings, 1 reply; 2+ messages in thread
From: John Garry @ 2018-04-19 14:14 UTC (permalink / raw)
  To: xuwei5
  Cc: arnd, geert+renesas, horms+renesas, gregkh, paul.gortmaker,
	robin.murphy, sebastien.bourdelin, bogdan.purcareata, tony,
	linux-kernel, linuxarm, helgaas, olof, khilman, tanxiaojun,
	John Garry

For ACPI support of the HiSilicon LPC driver we depend
on MFD_CORE config.

Currently the HiSi LPC Kconfig entry does not define this
dependency, so add it.

The reason for depending on MFD_CORE in the driver is
that we model the LPC host as an MFD, in that a platform
device will be created for each device on the bus. 

We do this as we need to modify the resources of these
derived platform devices, something which we should not
do to the original devices created in the ACPI scan.
Details in e0aa1563f894 ("HISI LPC: Add ACPI support").

Fixes: e0aa1563f894 ("HISI LPC: Add ACPI support")
Reported-and-tested-by: Tan Xiaojun <tanxiaojun@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
---

v1->v2 change:
- add details of reasong to use MFD to commit message

diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index d1c0b60..6dc177b 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -33,6 +33,7 @@ config HISILICON_LPC
 	bool "Support for ISA I/O space on HiSilicon Hip06/7"
 	depends on ARM64 && (ARCH_HISI || COMPILE_TEST)
 	select INDIRECT_PIO
+	select MFD_CORE if ACPI
 	help
 	  Driver to enable I/O access to devices attached to the Low Pin
 	  Count bus on the HiSilicon Hip06/7 SoC.
-- 
1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] HISI LPC: Add Kconfig MFD_CORE dependency
  2018-04-19 14:14 [PATCH v2] HISI LPC: Add Kconfig MFD_CORE dependency John Garry
@ 2018-04-26 14:53 ` Arnd Bergmann
  0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2018-04-26 14:53 UTC (permalink / raw)
  To: John Garry
  Cc: xuwei (O),
	Geert Uytterhoeven, Simon Horman, gregkh, Paul Gortmaker,
	Robin Murphy, Sebastien Bourdelin, bogdan.purcareata,
	Tony Lindgren, Linux Kernel Mailing List, Linuxarm,
	Bjorn Helgaas, Olof Johansson, Kevin Hilman, tanxiaojun

On Thu, Apr 19, 2018 at 4:14 PM, John Garry <john.garry@huawei.com> wrote:
> For ACPI support of the HiSilicon LPC driver we depend
> on MFD_CORE config.
>
> Currently the HiSi LPC Kconfig entry does not define this
> dependency, so add it.
>
> The reason for depending on MFD_CORE in the driver is
> that we model the LPC host as an MFD, in that a platform
> device will be created for each device on the bus.
>
> We do this as we need to modify the resources of these
> derived platform devices, something which we should not
> do to the original devices created in the ACPI scan.
> Details in e0aa1563f894 ("HISI LPC: Add ACPI support").
>
> Fixes: e0aa1563f894 ("HISI LPC: Add ACPI support")
> Reported-and-tested-by: Tan Xiaojun <tanxiaojun@huawei.com>
> Signed-off-by: John Garry <john.garry@huawei.com>

Applied to fixes.

      Arnd

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-26 14:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19 14:14 [PATCH v2] HISI LPC: Add Kconfig MFD_CORE dependency John Garry
2018-04-26 14:53 ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).