LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: <rjw@rjwysocki.net>, <andriy.shevchenko@linux.intel.com>,
	<linux-acpi@vger.kernel.org>, <lenb@kernel.org>,
	<mika.westerberg@linux.intel.com>, <lorenzo.pieralisi@arm.com>
Cc: <linux-kernel@vger.kernel.org>, <arnd@arndb.de>,
	<graeme.gregory@linaro.org>, <helgaas@kernel.org>,
	<linuxarm@huawei.com>, <z.liuxinliang@hisilicon.com>,
	John Garry <john.garry@huawei.com>
Subject: [RFC PATCH 0/2] HISI LPC: Add PNP device support
Date: Fri, 20 Apr 2018 18:07:24 +0800	[thread overview]
Message-ID: <1524218846-169934-1-git-send-email-john.garry@huawei.com> (raw)

This patchset adds support for creating PNP devices
for devices attached to the HiSilicon LPC host bus.

Currently an mfd-cell (platform device) is created per
device on the bus for using ACPI-based firmware. As
such, we need require a platform driver for these
devices.

However for PNP-compatible devices, it would be better
to create a PNP device so that we may use the existing
PNP driver.

The PNP-compatible device we are interested in is the
8250-compatible UART on the Huawei D03 development
board. This uart has the following profile:
- IO space iotype
- no interrupt, so polling mode required
- 16550 compatible

Currently no platform driver exists for this. I did
send an RFC to add support to the 8250_dw driver, but
Andy Shevchenko suggested adding PNP support to the
host driver instead so we may use the appropriate PNP
driver (8250_pnp) without modification, see here:
https://lkml.org/lkml/2018/2/26/354

As for the implementation in this patchset, to avoid
the PNP scan from creating and adding the device,
we reuse the "enumeration_by_parent" flag to hold off
adding the PNP device, so the parent driver can modify
the IO resources to translate from the bus address
to the logical PIO address, and then add the device
for probing.

This solution is not good - hence the RFC. But I am
looking for suggestions on how to solve this.

Any opinions or ideas?

Thanks!

John Garry (2):
  ACPI / PNP: Don't add "enumeration_by_parent" devices
  HISI LPC: Add PNP device support

 drivers/bus/hisi_lpc.c     | 38 +++++++++++++++++++++++++++++++++++++-
 drivers/pnp/pnpacpi/core.c | 12 ++++++++----
 2 files changed, 45 insertions(+), 5 deletions(-)

-- 
1.9.1

             reply	other threads:[~2018-04-20 10:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20 10:07 John Garry [this message]
2018-04-20 10:07 ` [RFC PATCH 1/2] ACPI / PNP: Don't add "enumeration_by_parent" devices John Garry
2018-04-20 13:07   ` Mika Westerberg
2018-04-20 13:24     ` John Garry
2018-04-20 13:52       ` Mika Westerberg
2018-04-20 14:09         ` John Garry
2018-04-26 13:49           ` John Garry
2018-04-26 14:08             ` Mika Westerberg
2018-04-26 14:23               ` John Garry
2018-04-26 14:40                 ` Mika Westerberg
2018-04-27  9:17                 ` John Garry
2018-04-30  5:36                   ` Lee Jones
2018-04-30  9:00                     ` John Garry
2018-04-30  9:26                       ` Lee Jones
2018-04-30  9:35                         ` John Garry
2018-04-30 10:46                           ` Lee Jones
2018-04-30 10:57                             ` John Garry
2018-04-20 10:07 ` [RFC PATCH 2/2] HISI LPC: Add PNP device support John Garry
2018-04-20 12:50   ` Andy Shevchenko
2018-04-20 13:09     ` John Garry
2018-04-20 13:28       ` Andy Shevchenko
2018-04-20 13:32         ` John Garry
2018-04-20 13:12   ` Mika Westerberg
2018-04-20 13:36     ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524218846-169934-1-git-send-email-john.garry@huawei.com \
    --to=john.garry@huawei.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=graeme.gregory@linaro.org \
    --cc=helgaas@kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=z.liuxinliang@hisilicon.com \
    --subject='Re: [RFC PATCH 0/2] HISI LPC: Add PNP device support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).