LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: stable@vger.kernel.org, Azhar Shaikh <azhar.shaikh@intel.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	"open list:TPM DEVICE DRIVER" <linux-integrity@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Tomas Winkler <tomas.winkler@intel.com>
Subject: Re: [PATCH 0/3] v4.16 tpmdd backports
Date: Wed, 25 Apr 2018 10:53:32 -0700	[thread overview]
Message-ID: <1524678812.4100.9.camel@HansenPartnership.com> (raw)
In-Reply-To: <20180425110600.GA1996@kroah.com>

On Wed, 2018-04-25 at 13:06 +0200, Greg KH wrote:
> On Wed, Apr 25, 2018 at 01:44:20PM +0300, Jarkko Sakkinen wrote:
> > "tpm: add retry logic" caused merge conflicts so I picked couple of
> > other fixes in order to get it apply cleanly.
> 
> Are these only needed in 4.16.y?  Nothing earlier?

The retry one (tpm: add retry logic) could go back as far as you can,
but the bug it causes is rarely seen: mostly it's a failure of the
kernel trusted keys due to a tpm retry being interpreted as a fatal
error.  The number of users we have for kernel trusted keys seems to be
pretty small ...

I'd say if the backport works as is, go for it, but if we get a patch
apply failure, it's probably not worth trying to work out how to modify
the patch again until someone actually complains about the problem.

James

  reply	other threads:[~2018-04-25 17:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25 10:44 Jarkko Sakkinen
2018-04-25 10:44 ` [PATCH 1/3] tpm: cmd_ready command can be issued only after granting locality Jarkko Sakkinen
2018-04-25 10:44 ` [PATCH 2/3] tpm: tpm-interface: fix tpm_transmit/_cmd kdoc Jarkko Sakkinen
2018-04-25 10:44 ` [PATCH 3/3] tpm: add retry logic Jarkko Sakkinen
2018-04-25 11:06 ` [PATCH 0/3] v4.16 tpmdd backports Greg KH
2018-04-25 17:53   ` James Bottomley [this message]
2018-04-26 17:49     ` Greg KH
2018-05-01 11:55       ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524678812.4100.9.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=azhar.shaikh@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    --subject='Re: [PATCH 0/3] v4.16 tpmdd backports' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).