LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Chris Lew <clew@codeaurora.org> To: bjorn.andersson@linaro.org, andy.gross@linaro.org, david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com Cc: aneela@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, clew@codeaurora.org Subject: [PATCH v2 6/6] rpmsg: glink: Expose rpmsg name attr for glink Date: Wed, 25 Apr 2018 19:07:52 -0700 [thread overview] Message-ID: <1524708472-18263-7-git-send-email-clew@codeaurora.org> (raw) In-Reply-To: <1524708472-18263-1-git-send-email-clew@codeaurora.org> Expose the name field as an attr so clients listening to uevents for rpmsg can identify the edge the events correspond to. Signed-off-by: Chris Lew <clew@codeaurora.org> --- Changes since v1: - Add const to attribute struct - Get name from glink channel drivers/rpmsg/qcom_glink_native.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 1418926f6110..72240614d4ca 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -1552,6 +1552,22 @@ static void qcom_glink_work(struct work_struct *work) } } +static ssize_t rpmsg_name_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct rpmsg_device *rpdev = to_rpmsg_device(dev); + struct glink_channel *channel = to_glink_channel(rpdev->ept); + + return snprintf(buf, RPMSG_NAME_SIZE, "%s\n", channel->glink->name); +} +static DEVICE_ATTR_RO(rpmsg_name); + +static const struct attribute *qcom_glink_attrs[] = { + &dev_attr_rpmsg_name.attr, + NULL +}; +ATTRIBUTE_GROUPS(qcom_glink); + static void qcom_glink_device_release(struct device *dev) { struct rpmsg_device *rpdev = to_rpmsg_device(dev); @@ -1601,6 +1617,8 @@ struct qcom_glink *qcom_glink_native_probe(struct device *dev, return ERR_PTR(-ENOMEM); glink->dev = dev; + glink->dev->groups = qcom_glink_groups; + glink->tx_pipe = tx; glink->rx_pipe = rx; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-04-26 2:08 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-26 2:07 [PATCH v2 0/6] Add chrdev and name query support for GLINK Chris Lew 2018-04-26 2:07 ` [PATCH v2 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings Chris Lew 2018-04-26 2:07 ` [PATCH v2 2/6] rpmsg: glink: Store edge name for glink device Chris Lew 2018-04-26 2:07 ` [PATCH v2 3/6] rpmsg: glink: Use complete_all for open states Chris Lew 2018-04-26 2:07 ` [PATCH v2 4/6] rpmsg: Guard against null endpoint ops in destroy Chris Lew 2018-04-26 2:07 ` [PATCH v2 5/6] rpmsg: glink: Add support for rpmsg glink chrdev Chris Lew 2018-04-26 2:07 ` Chris Lew [this message] 2018-04-26 22:15 ` [PATCH v2 6/6] rpmsg: glink: Expose rpmsg name attr for glink kbuild test robot 2018-04-27 0:10 ` kbuild test robot 2018-04-27 1:24 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1524708472-18263-7-git-send-email-clew@codeaurora.org \ --to=clew@codeaurora.org \ --cc=andy.gross@linaro.org \ --cc=aneela@codeaurora.org \ --cc=bjorn.andersson@linaro.org \ --cc=david.brown@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=linux-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).