LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] memory: omap-gpmc: Avoid redundant NULL check
@ 2018-04-26 10:29 Roger Quadros
0 siblings, 0 replies; only message in thread
From: Roger Quadros @ 2018-04-26 10:29 UTC (permalink / raw)
To: tony; +Cc: ladis, linux-omap, linux-kernel, Roger Quadros
child->name cannot be NULL as we're already checking for it
in gpmc_probe_dt_children()
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
drivers/memory/omap-gpmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index 90a66b3..c215287 100644
--- a/drivers/memory/omap-gpmc.c
+++ b/drivers/memory/omap-gpmc.c
@@ -2060,8 +2060,8 @@ static int gpmc_probe_generic_child(struct platform_device *pdev,
* timings.
*/
name = gpmc_cs_get_name(cs);
- if (name && child->name && of_node_cmp(child->name, name) == 0)
- goto no_timings;
+ if (name && of_node_cmp(child->name, name) == 0)
+ goto no_timings;
ret = gpmc_cs_request(cs, resource_size(&res), &base);
if (ret < 0) {
--
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-04-26 10:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-26 10:29 [PATCH] memory: omap-gpmc: Avoid redundant NULL check Roger Quadros
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).