LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@kernel.org>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Masami Hiramatsu <mhiramat@kernel.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Jon Medhurst <tixy@linaro.org>, Will Deacon <will.deacon@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
David Howells <dhowells@redhat.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
"Tobin C . Harding" <me@tobin.cc>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Richter <tmricht@linux.ibm.com>,
akpm@linux-foundation.org, acme@kernel.org, rostedt@goodmis.org,
brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
stable@vger.kernel.org
Subject: [PATCH v3 2/7] kprobes: Show blacklist addresses as same as kallsyms does
Date: Fri, 27 Apr 2018 15:40:39 +0900 [thread overview]
Message-ID: <152481123945.22588.459569704440210836.stgit@devbox> (raw)
In-Reply-To: <152481117776.22588.1210388093668905564.stgit@devbox>
Show kprobes blacklist addresses under same condition of
showing kallsyms addresses.
Since there are several name conflict for local symbols,
kprobe blacklist needs to show each addresses so that
user can identify where is on blacklist by comparing
with kallsyms.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
Changes in v3:
- Updated based on the latest linus tree.
---
kernel/kprobes.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index 51096eece801..e7d7e3e8598a 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -2427,9 +2427,17 @@ static int kprobe_blacklist_seq_show(struct seq_file *m, void *v)
{
struct kprobe_blacklist_entry *ent =
list_entry(v, struct kprobe_blacklist_entry, list);
+ void *start = (void *)ent->start_addr, *end = (void *)ent->end_addr;
- seq_printf(m, "0x%px-0x%px\t%ps\n", (void *)ent->start_addr,
- (void *)ent->end_addr, (void *)ent->start_addr);
+ /*
+ * As long as kallsyms shows the address, kprobes blacklist also
+ * show it, Or, it shows null address and symbol.
+ */
+ if (!kallsyms_show_value())
+ start = end = NULL;
+
+ seq_printf(m, "0x%px-0x%px\t%ps\n", start, end,
+ (void *)ent->start_addr);
return 0;
}
next prev parent reply other threads:[~2018-04-27 6:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 6:39 [PATCH v3 0/7] kprobes: Fix %p in kprobes Masami Hiramatsu
2018-04-27 6:40 ` [PATCH v3 1/7] kprobes: Make blacklist root user read only Masami Hiramatsu
2018-04-27 6:56 ` Greg KH
2018-04-27 14:52 ` Masami Hiramatsu
2018-04-27 7:04 ` Ingo Molnar
2018-04-27 15:58 ` Masami Hiramatsu
2018-04-27 6:40 ` Masami Hiramatsu [this message]
2018-04-27 7:14 ` [PATCH v3 2/7] kprobes: Show blacklist addresses as same as kallsyms does Ingo Molnar
2018-04-27 16:10 ` Masami Hiramatsu
2018-04-27 6:41 ` [PATCH v3 3/7] kprobes: Show address of kprobes if " Masami Hiramatsu
2018-04-27 6:41 ` [PATCH v3 4/7] kprobes: Replace %p with other pointer types Masami Hiramatsu
2018-04-27 6:56 ` Ingo Molnar
2018-04-27 15:42 ` Masami Hiramatsu
2018-04-28 4:43 ` Masami Hiramatsu
2018-04-27 6:42 ` [PATCH v3 5/7] kprobes/x86: Fix %p uses in error messages Masami Hiramatsu
2018-04-27 6:58 ` Ingo Molnar
2018-04-27 15:06 ` Masami Hiramatsu
2018-04-27 6:42 ` [PATCH v3 6/7] kprobes/arm: " Masami Hiramatsu
2018-04-27 6:43 ` [PATCH v3 7/7] kprobes/arm64: " Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152481123945.22588.459569704440210836.stgit@devbox \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=arnd@arndb.de \
--cc=brueckner@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=schwidefsky@de.ibm.com \
--cc=stable@vger.kernel.org \
--cc=tixy@linaro.org \
--cc=tmricht@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--subject='Re: [PATCH v3 2/7] kprobes: Show blacklist addresses as same as kallsyms does' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).